Enable fixes/assits to edit other files #187
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
| void Function(analyzer_plugin.FileEditBuilder builder) buildFileEdit, | ||
| ); | ||
| void Function(analyzer_plugin.FileEditBuilder builder) buildFileEdit, { | ||
| String? customPath, |
There was a problem hiding this comment.
We'd need this on all addXFileEdit, such as addDartFileEdit
There was a problem hiding this comment.
Done. customPath parameter added to all addXFileEdit methods
|
Could you add tests for this? Also please sign the CLA 🙏 (cf above) |
added the customPath parameter to the other "addXFileEdit" methods
|
I've added the |
|
We'd need automated tests invoking those methods with the new parameters. |
rrousselGit
changed the title
|
I have checked the tests which are available and the changes of this pull request breaks none of them. |
|
I'll try to find the time to add tests. I guess those tests would require to be triggred by the melos command hereafter: dart_custom_lint> dart run melos exec --dir-exists=test "dart test" |
|
@matthiaslarisch Not adding tests is not an option. I can guide you on how to do it, but it's a must. This PR will not be merged without tests |
|
Here's a test which runs an assist creating a ChangeBuilder. dart_custom_lint/packages/custom_lint_core/test/assist_test.dart Lines 27 to 28 in c8b0ef8 You could reuse this principle to make an Assist which specifies a "path" when creating the changeBuilder |
|
This pull request was included in the pull request 199 which are the same codes changes but with matching tests. |
No description provided.