Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VSCode source.fixAll. #251

Open
Rapougnac opened this issue May 31, 2024 · 2 comments
Open

Support VSCode source.fixAll. #251

Rapougnac opened this issue May 31, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Rapougnac
Copy link

Describe the bug
In a project with a .vscode/settings.json file:

{
  "editor.codeActionsOnSave": {
    "source.fixAll": "explicit",
  }
}

This will not run custom_lint quick fixes on save, but successfully runs quick fixes of the base analyzer

To Reproduce
Any custom lint that has a quick fix.

Expected behavior
The most important quick fix should run

@Rapougnac Rapougnac added the bug Something isn't working label May 31, 2024
@rrousselGit
Copy link
Collaborator

This isn't something that custom_lint can deal with.
The issue is analyzer_plugin ; which doesn't offer a way to react to "fix all" events.

@rrousselGit rrousselGit changed the title VSCode source.fixAll isn't respected with custom_lint package. Support VSCode source.fixAll. May 31, 2024
@rrousselGit rrousselGit added enhancement New feature or request and removed bug Something isn't working labels May 31, 2024
@rrousselGit
Copy link
Collaborator

dart-lang/sdk#55887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants