-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add out of the box support for YamlLint and YamlFix #263
Comments
It is low priority for me. But sure |
cc @Rexios80 If you're following to work on this, I'm open to guiding you on it :) |
Do you have any thoughts on this? Linting yaml files kind of works, but the plugin doesn't get notified about updates to yaml files. I tried adding *.yaml to the interestingFiles field here, but that somehow broke yaml file linting completely. dart_custom_lint/packages/custom_lint/lib/src/v2/custom_lint_analyzer_plugin.dart Line 330 in b50bd2b
Ideally we pass in the globs from LintRule.filesToAnalyze, but I was just trying to get a proof of concept working. |
Analyzer_plugin is likely the issue here. I'd suggest raising an issue on the dart sdk for that. There's likely already one |
Actually it looks like |
You need to edit the tools/analyzer_plugin/pubspec.yaml
|
You may have to clear your pub cache after editing the pubspec too. Or your change may not get picked up. Analyzer_plugins are ... let's say ... not exactly easy to use. |
Is that in the documentation somewhere? I looked but couldn't find it. Maybe we should add this to a CONTRIBUTING.md file? |
There's a TODO in the pubspec, but a CONTRIBUTING.md could be good too. |
I think I got it kind of working by symlinking my fork of custom_lint into the pub cache, but I still can't get yaml lints to update in real time. I don't have the bandwidth to diagnose this at the moment, so I'm giving up for now. |
As I mentioned, the update issue is likely not from custom_lint |
Is your feature request related to a problem? Please describe.
For me, it's quite difficult at the moment to write custom lints for yaml files. To write a lint is possible, but I can't make the fixes work. It would be nice if the package could offer a simple solution for that, like with
DartLint
andDartFix
.Describe the solution you'd like
Add corresponding
YamlLint
andYamlFix
class.Describe alternatives you've considered
Add a guide on how to write linter rules for files others than dart.
The text was updated successfully, but these errors were encountered: