-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for 'package:' configs #205
Conversation
This reverts commit 98931bc.
…figs Add support for including 'package:' configs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…figs Applied changes suggested in main repo
Hey @rrousselGit, I've applied your suggestions. Would be really grateful for your approval :) |
Unfortunately, we won't be able to let you edit this PR since it has been created from the organization's fork. |
Nice! I was about to say the parameter didn't have to be nullable, but you caught it first :) |
I've committed it but then figured out that tests are broken. Give me please one more commit to fix this |
@rrousselGit That's also done! |
Add Support for 'package:' configs
Description
This pull request introduces support for including configurations using 'package:' URI.
Changes Made
Isolate.resolvePackageUri
method.parse()
methodMotivation
The motivation behind this enhancement is to allow users to include rule configurations from packages.
Usage Example
analysis_options.yaml
Testing