Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for 'package:' configs #205

Merged
merged 35 commits into from
Jan 9, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2023

Add Support for 'package:' configs

Description

This pull request introduces support for including configurations using 'package:' URI.

Changes Made

  1. configs.dart
    • Added parsing logic to interpret 'package:' configurations using asynchronous Isolate.resolvePackageUri method
    • Changed factory method to static async method
  2. tests
    • Made tests asynchronous to use async .parse() method

Motivation

The motivation behind this enhancement is to allow users to include rule configurations from packages.

Usage Example

analysis_options.yaml

include: package:your_package/analysis_options.yaml

Testing

  • Covered 'package:' URI including with tests

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
custom-lint-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 4:09pm

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2023

CLA assistant check
All committers have signed the CLA.

Daniil Marchenko and others added 2 commits November 27, 2023 16:02
@ghost
Copy link
Author

ghost commented Nov 28, 2023

Hey @rrousselGit, I've applied your suggestions. Would be really grateful for your approval :)

@ghost
Copy link
Author

ghost commented Jan 5, 2024

I don't have permissions to make changes on this PR. Could you check the box for it?

Unfortunately, we won't be able to let you edit this PR since it has been created from the organization's fork.
We could invite you to our repository so you can make changes directly.

@rrousselGit
Copy link
Collaborator

Nice! I was about to say the parameter didn't have to be nullable, but you caught it first :)

@ghost
Copy link
Author

ghost commented Jan 8, 2024

Nice! I was about to say the parameter didn't have to be nullable, but you caught it first :)

I've committed it but then figured out that tests are broken. Give me please one more commit to fix this

@ghost
Copy link
Author

ghost commented Jan 8, 2024

Nice! I was about to say the parameter didn't have to be nullable, but you caught it first :)

I've committed it but then figured out that tests are broken. Give me please one more commit to fix this

@rrousselGit That's also done!

@rrousselGit rrousselGit merged commit 6120a44 into invertase:main Jan 9, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants