-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expo): Do not publish plugin tests and sources to NPM #5565
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9FU1LbJ5hBqUJM9e2TcH1bjqLe17 react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/DFp9YCMnHn8eGr8EPqgYUyrdzsMS |
Codecov Report
@@ Coverage Diff @@
## master #5565 +/- ##
============================================
+ Coverage 67.56% 71.17% +3.62%
============================================
Files 199 106 -93
Lines 9659 4405 -5254
Branches 1510 941 -569
============================================
- Hits 6525 3135 -3390
+ Misses 2719 1173 -1546
+ Partials 415 97 -318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch. Normally I'm a big proponent of shipping source with the package (to enable "drive-by" PRs via patch-package and the like), but in a monorepo that's not really even possible, so it is just inflating the package size with no benefit I can see
* [app] npm ignore expo plugin source * [crashlytics] npm ignore expo config plugin src * [perf] npm ignore expo config plugin src tests
Description
I noticed that the whole
plugin
directory is published to NPM. The only subdirectory really needed isplugin/build
, others (src, tests) can be npm-ignored to make the package smaller.The
plugin/build
dir is generated fromplugin/src
duringnpm prepare
step. Its content is required by theapp.plugin.js
file.Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
🤷
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter