fix(app-distribution, ios): missing downloadURL

[YukiKitagata]

Description

I found a bug that downloadURL was not being passed.

I have reviewed the implementation, and it seems that the NSURL is directly passed to resolve, and becomes null when it is serialized by RN.

NSURL is converted to String by accessing the absoluteString property, so this bug is fixed.

Related issues

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/GZvtTTFUFZ6STwgeAwnvJzpE775p
✅ Preview: Canceled

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DnPPkV1KELhv6PWwb5oyy8Jm63i3
✅ Preview: https://react-native-firebase-git-fork-n1nc-fix-missin-3bf473-invertase.vercel.app

[codecov]

Codecov Report

Merging #5668 (62c9fab) into master (41c0107) will increase coverage by 19.43%.
The diff coverage is n/a.

❗ Current head 62c9fab differs from pull request most recent head 58ceab5. Consider uploading reports for the commit 58ceab5 to get more accurate results

@@              Coverage Diff              @@
##             master    #5668       +/-   ##
=============================================
+ Coverage     53.65%   73.08%   +19.43%     
=============================================
  Files           208      109       -99     
  Lines         10084     4487     -5597     
  Branches       1543      957      -586     
=============================================
- Hits           5410     3279     -2131     
+ Misses         4391     1129     -3262     
+ Partials        283       79      -204     

[mikehardy]

Another trivial/obvious error in the implementation, you have my continued appreciation for helping clean these up. I clearly need to figure out a way / any way to test these in E2E some how. This has me worried about the Android implementation as well...

[YukiKitagata]

@mikehardy

Thanks for the quick response!
I also hope that E2E can prevent this kind of bug from happening...
I'll check it out when I get a chance to use it on Android :)