App / Expo plugin - iOS might break with Expo SDK 43

[barthap]

Not sure where to post it, it's not a problem yet, feel free to move/edit this issue.

Because of this commit in expo (scroll to AppDelegate.m),
The @rnfb/app plugin will likely stop working, because of this regex

We need to find a way to make that regex work more flexible - to support both old and new AppDelegate template.

[mikehardy]

Interesting - the link for this regex wasn't coming out to a useful spot for me, so I couldn't put 1+1 together to make the 2 you were intending :-). Could you check?

[barthap]

This regex expects lines which were removed in SDK 43 template of app delegate.

[barthap]

A bunch of updates (if any link posted here fails, just lmk - sometimes I have this issue with github too):

• There is a more universal regex in one of unofficial plugins: link to line 122 in withIosGoogleCast.ts

  It looks terrible but it seems to work: regex101.com example

• If you scroll down the code above, there's a mergeContents() (source here - line 35) method available, which tries to add/replace code in a more controlled manner + adds comments about auto-generated places & some hashes. I haven't tried this functionality yet, but looks promising.
  Edit: And this looks even more promising: [config-plugins] introduce codeMod expo/expo-cli#3909

• The same issue happens to some built-in expo plugins 🤷 - Evan Bacon declared to follow up this - we can just wait, then do the same here 😉 but having the tools above we could act early too.

[EvanBacon]

For expo-firebase-core, we'll be utilizing the expo-modules-core AppDelegate proxy system (PR) which is the long term replacement for config plugin regular expressions.
We'll investigate some non-intrusive options for other packages to support the proxy as well but in the meantime, our new default AppDelegate.m template is nearly identical (if not completely identical) to the default React Native AppDelegate.m template (of the matching version), this means that Expo config plugins which were accounting for both will continue working, example react-native-maps.

I'd recommend updating the RNFirebase plugin to account for both (like maps) to avoid needing any versioning.