-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, android): firebase-android-sdk 29.0.3 to fix underlying NPE in 29.0.2 #5946
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/HQxGHfrTiRfa94XvnaUkFSCk3Ugh react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/EYTEfeyUgFR12f4Eq7fQEKLN4v9F [Deployment for 804c16a canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! DIdn't realize they had a crash bug in 29.0.2 - they don't do formal releases on github so there is nothing to "watch" and I don't get notified 😅 - until I release this, please know that you can a) use the patch-package set from the actions here or b) you can do the override in your build.gradle to make sure you don't have any NullPointerExceptions - https://rnfirebase.io/#android
I'm going to edit the title to just be a fix though, it's only a patch release from them, should only be a patch release from us :-). Cheers!
Codecov Report
@@ Coverage Diff @@
## main #5946 +/- ##
============================================
- Coverage 53.04% 52.68% -0.35%
Complexity 622 622
============================================
Files 208 208
Lines 10171 10171
Branches 1618 1618
============================================
- Hits 5394 5358 -36
- Misses 4523 4556 +33
- Partials 254 257 +3 |
Even for small fixes we need the CLA signed if you could? The details link on the CLA comment + action have more info on how |
@mikehardy Yes of course! The CLA is already added it! I see the Adding this word in the .spellcheck.dict.txt file should work, right? |
Yep, adding it to the spelling dictionary sounds perfect |
Done @mikehardy, I am really amazed by all the checks you have set up in the library, |
Awesome thanks. And yeah, quality is really really important for a library this fundamental. The automation is the only way to have confidence we maintain the level we expect while making changes |
Description
I'm updating the latest version of this library in our app so we can collect ANR issues using the latest version of Firebase Crashlytics, so when reading the Firebase Android BoM documentation I saw that they sent a patch yesterday to avoid a crash (NullPointerException) with the previous version of the firebase analytics library:
https://issuetracker.google.com/issues/210908929
So I think it will be wonderful to have the most stable version. 👍🏽
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
No breaking changes, only internal changes in the android firebase analytics library
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter🔥