-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): data bundles API #6199
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9AyXnLYQ6CKHZ4DSLMuZpQvJVXqF react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/CRJYE2X3tGbgsKpHjaxZmNnX6CTp [Deployment for 00d0009 canceled] |
Codecov Report
@@ Coverage Diff @@
## main #6199 +/- ##
=============================================
- Coverage 72.11% 53.48% -18.63%
- Complexity 0 649 +649
=============================================
Files 109 208 +99
Lines 4618 10302 +5684
Branches 1040 1633 +593
=============================================
+ Hits 3330 5509 +2179
- Misses 1210 4539 +3329
- Partials 78 254 +176 |
...ges/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java
Show resolved
Hide resolved
I think the android test failure in e2e ci was a flaky test, I restarted it |
.../android/src/main/java/io/invertase/firebase/firestore/UniversalFirebaseFirestoreModule.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! I pulled it locally and stabilized it across repeated runs via test:<platform>:test-reuse
where you need to call firestore().clearPersistence()
on startup so that there are no cached non-bundle docs before the run, but otherwise it just worked.
This was one of the flagship features added to firebase in 2021 and it really nagged me that we didn't have it yet, I truly appreciate your posting this! Hopefully lots of people put it to use and enjoy some cost savings
Wow, thanks for a quick merge & release! |
Ha! I actually felt like 7 days after you were done before merge was patient on your part! There is no real bureaucracy here so things can move really quickly, I was pretty behind, from work on other repos 😅 |
I think my last week went by like crazy that I felt it short. 😂 And don't have to be sorry about the "behind", I always appreciate your tremendous work in maintaining the library! |
Description
Add Firestore bundles API:
loadBundle()
andnamedQuery()
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter