fix(app-check, types): Correct ReactNativeFirebaseAppCheckProvider options type #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
frw
changed the title
mikehardy
previously approved these changes
Feb 15, 2023
mikehardy
reviewed
Feb 15, 2023
mikehardy
changed the title
exaby73
pushed a commit
that referenced
this pull request
Aug 8, 2023
…tions type (#6911) * fix(appcheck): Fixed ReactNativeFirebaseAppCheckProvider options type * Update packages/app-check/lib/index.d.ts --------- Co-authored-by: Mike Hardy <github@mikehardy.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the recent update to AppCheck types in 17.2.0, there is still an issue with configuring ReactNativeFirebaseAppCheckProvider when attempting to follow https://rnfirebase.io/app-check/usage:
The issue is due to a mismatch in the TypeScript declaration file.
ReactNativeFirebaseAppCheckProvidertakes in a single options object:https://github.com/invertase/react-native-firebase/blob/main/packages/app-check/lib/ReactNativeFirebaseAppCheckProvider.js#L6
while the type declaration indicates it takes in 4 separate objects for each platform:
https://github.com/invertase/react-native-firebase/blob/main/packages/app-check/lib/index.d.ts#L139-L142
Related issues
Fixes #6886
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter