Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, types): add OIDCProvider to typescript declaration #6936

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

paulrostorp
Copy link
Contributor

Description

#6574 added support for the OIDCProvider provider, but it was not added to the typescript declaration file.
cc: @Babsvik @mikehardy

Related issues

Release Summary

  • auth: add missing OIDCProvider to typescript declaration

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 1:49PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Feb 24, 2023 at 1:49PM (UTC)

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Frustrating oversight as it's so obvious. Sorry about that, and I really appreciate the PR to fix

@mikehardy mikehardy changed the title fix(auth): add OIDCProvider to typescript declaration fix(auth, types): add OIDCProvider to typescript declaration Feb 25, 2023
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 25, 2023
@mikehardy
Copy link
Collaborator

the e2e harness doesn't use typescript so all the tests necessary to see this work have passed. I typically release a bit more quickly then once a week on average so this will go out soon, in the meantime you can patch-package locally if you haven't already - there's a CI job above ☝️ that generates a patch-set from the mono-repo so it's not so painful, assuming you haven't patched it yourself already :-)

@mikehardy mikehardy merged commit 00185a3 into invertase:main Feb 25, 2023
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 25, 2023
@Babsvik
Copy link
Contributor

Babsvik commented Mar 1, 2023

Thanks for fixing the typescript definitions @paulrostorp ! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants