fix(firestore): Allow queries with combined in and array-contains-any

[ibobo]

Description

Since late april queries containing in and array-contains-any together are supported as queries with multiple in statements, given that the number of generated or queries in normal form is below 30. Since @react-native-firebase/firestore is currently blocking any of these queries, this PR aims at removing that block, leaving the check for the normal form limit to the underlying firestore engine.

This is the relevant firebase docs on these limitations: https://firebase.google.com/docs/firestore/query-data/queries#limitations_3

Please note: I do not have a history of the changes available, I know this change has been added with the or operator support.

Related issues

None

Release Summary

Allow the use of in and array-contains-any in the same query.

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

I ran the e2e tests, these are the results:

  1679 passing (3m)
  116 pending

Apart from running e2e tests I did use my fork in my own project using the aforementioned in and array-contains-any filters in some queries, and they work fine.

🔥

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2023 8:26am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase-next	⬜️ Ignored (Inspect)			May 30, 2023 8:26am

[CLAassistant]

All committers have signed the CLA.

[mikehardy]

Fascinating - you are exactly right! This was changed recently and makes the query language much more powerful, assuming we let them through our filtering :-). Thanks for taking the time to fix this not just for yourself but for all users, much appreciated!

[mikehardy]

The iOS CI failure is a timeout I'm fixing in #7163 and does not affect this PR - will merge this after that one passes CI so it doesn't fail on main as well post-merge

[codecov]

Codecov Report

Merging #7142 (01974cd) into main (a58ea4b) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7142      +/-   ##
============================================
- Coverage     54.00%   53.98%   -0.02%     
  Complexity      734      734              
============================================
  Files           230      230              
  Lines         11503    11497       -6     
  Branches       1854     1851       -3     
============================================
- Hits           6211     6205       -6     
  Misses         4949     4949              
  Partials        343      343