Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability because of deprecated request npm dependency #15

Closed
schuerg opened this issue Apr 9, 2023 · 0 comments · Fixed by #16
Closed

Security vulnerability because of deprecated request npm dependency #15

schuerg opened this issue Apr 9, 2023 · 0 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@schuerg
Copy link

schuerg commented Apr 9, 2023

The npm depdency request has known security vulnerabilities and is deprecated for long time now.

> npm audit
request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
No fix available
node_modules/request
  domrobot-client  *
  Depends on vulnerable versions of request
  Depends on vulnerable versions of request-promise-native
  node_modules/domrobot-client
  request-promise-core  *
  Depends on vulnerable versions of request
  node_modules/request-promise-core
    request-promise-native  >=1.0.0
    Depends on vulnerable versions of request
    Depends on vulnerable versions of request-promise-core
    node_modules/request-promise-native

4 moderate severity vulnerabilities

This dependency should be replaced by a modern http client. E.g. with the Node.js native and browser compatible fetch API or something else. request/request#3143


@ab7z ab7z self-assigned this Jul 3, 2023
@ab7z ab7z added the enhancement New feature or request label Jul 3, 2023
@ab7z ab7z linked a pull request Jul 3, 2023 that will close this issue
@ddmler ddmler closed this as completed in #16 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants