Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Reimplement //rotate and //flip #252

Open
10 tasks
inxomnyaa opened this issue Jul 9, 2022 · 0 comments · May be fixed by #253
Open
10 tasks

[TODO] Reimplement //rotate and //flip #252

inxomnyaa opened this issue Jul 9, 2022 · 0 comments · May be fixed by #253
Labels
State: In Progress TODO

Comments

@inxomnyaa
Copy link
Owner

Description:
Due to extracting blockstates into a virion (see #236), the rotate and flip method had to be removed to loosen up the dependency on MWE2.

I have already added API::rotate() in this branch: flip-rotate. As of now it only supports changing the block positions, not the states though.

TODO list:

  • Implement blockstate modifications
  • Implement flip
  • Correct counterclockwise => clockwise
  • Update rotation and flip data json
  • Implement rotating around origin/center
  • Correct pasting in new chunks not working
  • Allow -90 as rotation degrees parameter as synonym for 270
  • Fix Rotate- & FlipAction not updating progress / calculating changed count
  • Remove unnecessary try-catch blocks
  • Allow rotating .mcstructure files
@inxomnyaa inxomnyaa linked a pull request Jul 9, 2022 that will close this issue
Open
@inxomnyaa inxomnyaa linked a pull request Jul 9, 2022 that will close this issue
Add back //flip and //rotate #253
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
State: In Progress TODO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back //flip and //rotate inxomnyaa/MagicWE
1 participant
@inxomnyaa