Improvements for kde operation error, dimension and range handling #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
stats_operation_fixes
branch
from
e6b93cf
to
98221fe
Compare
philippjfr
force-pushed
the
stats_operation_fixes
branch
from
98221fe
to
e599b99
Compare
philippjfr
force-pushed
the
stats_operation_fixes
branch
from
4f8e010
to
fac157e
Compare
|
Have added tests now, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some bugs in the univariate_kde dimension handling but I've also included improvements to range and exception handling for both kde operations.
I'll add some more unit tests before this is ready to merge.