Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for "Playing" is not fully updated #11

Closed
udochrist opened this issue Sep 22, 2019 · 10 comments
Closed

Metadata for "Playing" is not fully updated #11

udochrist opened this issue Sep 22, 2019 · 10 comments
Assignees
Labels
bug Something isn't working verify-fix Verify if the implemented fix has solved the issue

Comments

@udochrist
Copy link

udochrist commented Sep 22, 2019

i have played in Succession on the Same Device:

  • a Movie that is part of a "Collection" in Plex
  • an Episode from a TV Show.

Looking at the Metadata displayed in iobroker I see that the media is shown as the TV Show ep, the collection is however still that of the movie played earlier.
I think some of the fields are not cleaned/updated when a new item gets played.

@Zefau
Copy link
Collaborator

Zefau commented Sep 22, 2019

Which adapter version are you on? What's your Node.js version? Are you using Plex Pass? Are you using Tautulli Webhook?

Could you set the instance to debug and provide the log of playing both the items?
Which are the fields / states which are not updated?

@Zefau Zefau added the bug Something isn't working label Sep 22, 2019
@udochrist
Copy link
Author

Hi Zefau,
thanks for picking this up. i'm using the plexpass setup with version 0.60 of the adapter. Node is 10.6.2, iobroker 1.5.14 if i understand the versioning correct.

i don't know how to enable debug logging on the plex.0 instance, but i don't like posting logfiles anyway. i've stopped and started the adapter to remove all _playing entries (this is enabled at my end), played a movie belonging to a collection "The Cornetto Trilogy", ended the movie, marked it played and played a tv ep from NCIS LA. All on a web browser.

here are screenshots of the iobrokers objects:
Movie started
Movie started

Movie stopped and marked watched.
(NB:with stopping i would actually have expected the _playing vars to empty out.)
Movie stopped

Playing the TV ep.
(You can see that the collection is still from the movie, while the grandparenttitle shows the correct show name)
tv ep started

cheers

@Zefau Zefau added this to To do in Plex ROADMAP Oct 6, 2019
@Zefau Zefau moved this from To do to Done in Plex ROADMAP Oct 6, 2019
@Zefau Zefau moved this from Done to In progress in Plex ROADMAP Oct 6, 2019
@Zefau
Copy link
Collaborator

Zefau commented Oct 6, 2019

Sorry for the delay. I have been working on this today and will provide an update next week.

@Zefau
Copy link
Collaborator

Zefau commented Oct 17, 2019

@udochrist Sorry again for the delay. Could you try and install v0.7.0 from Github? This should address this bug.

iobroker url https://github.com/Zefau/ioBroker.plex

@udochrist
Copy link
Author

udochrist commented Oct 17, 2019

tested it.

issue is still the same for the same use case. i also did the test vice versa and switched from a tv episode to a movie and the same issue is with i.e. the grandParentXYZ fields.

the log now shows some more warnings however


plex.0 | 2019-10-17 21:58:38.000 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:58:28.604 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:58:04.576 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:57:42.235 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:57:01.455 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:56:55.051 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:56:23.577 | warn | (3142) library.runGarbageCollector is not a function
plex.0 | 2019-10-17 21:56:20.409 | warn | (3142) library.runGarbageCollector is not a function

EDT: and don't worry. this is by far not mission critical stuff.

@Zefau
Copy link
Collaborator

Zefau commented Oct 17, 2019

Sorry, forgot to update the library, which actually provides the function library.runGarbageCollector. Could you update from Github once more? Thanks

@udochrist
Copy link
Author

warnings are gone, but issue is not fully fixed.
from the original test case the collection is now no longer populated. this is correct.
however switching from a tv ep to a movie still keeps the grandParentXYZ fields from the tv ep.

@udochrist
Copy link
Author

BTW: since the last update i get quite some logs complainig about "undefined"

plex.0 | 2019-10-22 08:18:03.076 | warn | (872) Cannot read property '_playing.udosipadpro2-<GUID>' of undefined
plex.0 | 2019-10-22 08:18:02.637 | warn | (872) Cannot read property '_playing.udosipadpro2-<GUID>' of undefined
plex.0 | 2019-10-22 08:17:51.946 | warn | (872) Cannot read property '_playing.udosipadpro2-<GUID>' of undefined

@Zefau
Copy link
Collaborator

Zefau commented Oct 28, 2019

Please check out v0.8.0 if this release solves this issue now completely. Thanks.

@Zefau Zefau added the verify-fix Verify if the implemented fix has solved the issue label Oct 28, 2019
@Zefau Zefau self-assigned this Oct 28, 2019
@Zefau Zefau moved this from In progress to In test in Plex ROADMAP Oct 28, 2019
@udochrist
Copy link
Author

Hi. Excellent work. Metadata is now fully matching the played item (tested tv, music and movie switching). Plus there are no more warnings in the log.

@Zefau Zefau moved this from In test to Done in Plex ROADMAP Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verify-fix Verify if the implemented fix has solved the issue
Projects
Plex ROADMAP
  
Done
Development

No branches or pull requests

2 participants