Skip to content

Commit

Permalink
net: remove use of arguments in Server constructor
Browse files Browse the repository at this point in the history
The current implementation uses the arguments object in the Server()
constructor. Since both arguments to Server() are optional, there was a
high likelihood of accessing a non-existent element in arguments, which
carries a performance overhead. This commit replaces the arguments
object with named arguments.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>

Conflicts:
	lib/net.js
  • Loading branch information
cjihrig committed Feb 13, 2015
1 parent 4ca7cca commit cca8de6
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ function isPipeName(s) {
return typeof s === 'string' && toNumber(s) === false;
}

exports.createServer = function() {
return new Server(arguments[0], arguments[1]);
exports.createServer = function(options, connectionListener) {
return new Server(options, connectionListener);
};


Expand Down Expand Up @@ -991,22 +991,24 @@ function afterConnect(status, handle, req, readable, writable) {
}


function Server(/* [ options, ] listener */) {
if (!(this instanceof Server)) return new Server(arguments[0], arguments[1]);
function Server(options, connectionListener) {
if (!(this instanceof Server))
return new Server(options, connectionListener);

events.EventEmitter.call(this);

var self = this;

var options;

if (typeof arguments[0] === 'function') {
if (typeof options === 'function') {
connectionListener = options;
options = {};
self.on('connection', arguments[0]);
self.on('connection', connectionListener);
} else {
options = arguments[0] || {};
options = options || {};

if (typeof arguments[1] === 'function') {
self.on('connection', arguments[1]);
if (typeof connectionListener === 'function') {
self.on('connection', connectionListener);
}
}

Expand Down

0 comments on commit cca8de6

Please sign in to comment.