Skip to content

Commit

Permalink
doc: adding thlorenz to list of collaborators
Browse files Browse the repository at this point in the history 
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>, Jeremiah Senkpiel <fishrock123@rocketmail.com>, Bert Belder <bertbelder@gmail.com>
PR-URL: #577
  • Loading branch information
@thlorenz
thlorenz committed Jan 23, 2015
1 parent 8de89ec commit f3fed51
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ information about the governance of the io.js project, see
* **Colin Ihrig** ([@cjihrig](https://github.com/cjihrig)) &lt;cjihrig@gmail.com&gt; (Technical Committee)
* **Mikeal Rogers** ([@mikeal](https://github.com/mikeal)) &lt;mikeal.rogers@gmail.com&gt;
* **Rod Vagg** ([@rvagg](https://github.com/rvagg)) &lt;rod@vagg.org&gt;
* **Thorsten Lorenz** ([@thlorenz](https://github.com/thlorenz)) &lt;thlorenz@gmx.de&gt;

Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
maintaining the io.js project.

4 comments on commit f3fed51

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, nits here, but something like this is the more typical commit formatting: 5ba307a

@thlorenz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, I'll keep that in mind for next time, thanks.

@rvagg
Copy link
Member

@rvagg rvagg commented on f3fed51 Jan 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis are we ok with the reviewed-by list being on a single line here? Does it matter for any reason?

@bnoordhuis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvagg et al, I would prefer one Reviewed-By line per reviewer. It makes it easier to parse from a script.

EDIT: Also, because of the 72 column limit.

Please sign in to comment.