Skip to content

Commit

Permalink
src: fix add-on builds, partially revert 8aed9d66
Browse files Browse the repository at this point in the history
Commit 8aed9d66 ("src: cleanup `Isolate::GetCurrent()`") breaks building
add-ons because of the following:

    In file included from ../node_modules/nan/nan.h:27:0,
                     from ../src/binding.cc:18:
    /home/bnoordhuis/src/v1.x/src/node_object_wrap.h: In member function
    'v8::Local<v8::Object> node::ObjectWrap::handle()':
    /home/bnoordhuis/src/v1.x/src/node_object_wrap.h:39:46: error: base
    operand of '->' has non-pointer type 'v8::Persistent<v8::Object>'
         return v8::Local<v8::Object>::New(handle_->GetIsolate(),
                                           persistent());

Mea culpa, I was one of the reviewers.

PR-URL: #868
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
  • Loading branch information
bnoordhuis authored and vkurchatkin committed Feb 17, 2015
1 parent 0555b3c commit fb28c91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_object_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ObjectWrap {


inline v8::Local<v8::Object> handle() {
return v8::Local<v8::Object>::New(handle_->GetIsolate(), persistent());
return handle(v8::Isolate::GetCurrent());
}


Expand Down

0 comments on commit fb28c91

Please sign in to comment.