deps: upgrade v8 to 4.2.77.10 (next) #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, postmortem! Let me figure it out first, and then land with a floating patch while Google will be reviewing it. |
|
|
|
Exactly. :-) I'm going to squash the PR into a single commit before landing it. The |
|
@indutny Ping. |
|
Got distracted, looking again into it. |
|
@bnoordhuis here is a fix: diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py
index 62e103a..d5defa7 100644
--- a/deps/v8/tools/gen-postmortem-metadata.py
+++ b/deps/v8/tools/gen-postmortem-metadata.py
@@ -91,7 +91,7 @@ consts_misc = [
{ 'name': 'prop_idx_first',
'value': 'DescriptorArray::kFirstIndex' },
{ 'name': 'prop_type_field',
- 'value': 'FIELD' },
+ 'value': 'DATA' },
{ 'name': 'prop_type_mask',
'value': 'PropertyDetails::TypeField::kMask' },
{ 'name': 'prop_index_mask',Please float it up. I'm submitting a CL atm. |
This commit applies some secondary changes in order to make `make test` pass cleanly: * disable broken postmortem debugging in common.gypi * drop obsolete strict mode test in parallel/test-repl * drop obsolete test parallel/test-v8-features PR-URL: nodejs#1232 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Cherry-pick https://codereview.chromium.org/1033733003 from upstream and re-enable postmortem debugging. PR-URL: nodejs#1232 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
force-pushed
the
v8-4.2.77.10
branch
from
f28aea7 to
41c00a2
Compare
|
Landed in 336dc08...41c00a2. You didn't explicitly LGTM it but I added you as a reviewer, Fedor. |
|
Oh, sorry for that! LGTM ;) |
bnoordhuis
added a commit
that referenced
this pull request
Apr 28, 2015
This commit applies some secondary changes in order to make `make test` pass cleanly: * disable broken postmortem debugging in common.gypi * drop obsolete strict mode test in parallel/test-repl * drop obsolete test parallel/test-v8-features PR-URL: #1232 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
added a commit
that referenced
this pull request
Apr 28, 2015
Cherry-pick https://codereview.chromium.org/1033733003 from upstream and re-enable postmortem debugging. PR-URL: #1232 Reviewed-By: Fedor Indutny <fedor@indutny.com>
bnoordhuis
added a commit
that referenced
this pull request
Apr 28, 2015
Cherry-pick https://codereview.chromium.org/1033733003 from upstream and re-enable postmortem debugging. PR-URL: #1232 Reviewed-By: Fedor Indutny <fedor@indutny.com>
rvagg
added
the
semver-major
This was referenced Apr 24, 2023
This was referenced Jul 8, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@indutny?
I disabled postmortem debugging because it's broken again and I deleted parallel/test-v8-features because it's obsolete now that ES6 classes are enabled by default.
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/358/