src: cleanup Isolate::GetCurrent()
#807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM FWIW |
|
Great stuff. LGTM. @bnoordhuis on the C++ side, your opinion is always worth more than mine. ;-) |
trevnorris
pushed a commit
to trevnorris/node
that referenced
this pull request
Feb 11, 2015
PR-URL: nodejs#807 Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks. Landed in 8aed9d6. |
|
@trevnorris can't see it. you probably pushed to the wrong remote :) |
|
pushed it myself, still 8aed9d6 |
|
@vkurchatkin thanks. yeah, wrong remote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris