From bf10674f5d00fc3313bfccc9abfb46e0cd337348 Mon Sep 17 00:00:00 2001 From: Masahiko Sakakibara Date: Wed, 1 Aug 2018 03:55:20 +0900 Subject: [PATCH] fix(serve): await connectivity on specified host, not localhost (#3444) --- packages/@ionic/cli-utils/src/lib/project/angular/serve.ts | 2 +- .../@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts | 2 +- packages/@ionic/cli-utils/src/lib/project/ionic1/serve.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts b/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts index cc6831caf4..e207c101f8 100644 --- a/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts +++ b/packages/@ionic/cli-utils/src/lib/project/angular/serve.ts @@ -104,7 +104,7 @@ ${chalk.cyan('[1]')}: ${chalk.bold('https://github.com/angular/angular-cli/wiki/ this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`); }, 5000); - await isHostConnectable('localhost', ngPort); + await isHostConnectable(options.address, ngPort); clearInterval(interval); return { diff --git a/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts b/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts index b701db6d34..62cd385885 100644 --- a/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts +++ b/packages/@ionic/cli-utils/src/lib/project/ionic-angular/serve.ts @@ -126,7 +126,7 @@ export class IonicAngularServeRunner extends ServeRunner { this.e.log.info(`Waiting for connectivity with ${chalk.green(program)}...`); }, 5000); - await isHostConnectable('localhost', port); + await isHostConnectable(options.address, port); clearInterval(interval); return {