-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translation/jp): 20240211 update #3437
Conversation
* chore: resolve cspell errors * chore: ignore all node_modules folders * chore: adjust sorting
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Conflicts: # docs/angular/testing.md # docs/api/checkbox.md # docs/api/datetime.md # docs/api/fab.md # docs/api/input.md # docs/api/item.md # docs/api/modal.md # docs/api/radio.md # docs/api/select.md # docs/api/toggle.md # docs/components.md # docs/core-concepts/what-are-progressive-web-apps.md # docs/react/navigation.md # docs/react/pwa.md # docs/theming/advanced.md # docs/vue/overview.md # docs/vue/quickstart.md # package-lock.json # package.json
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ed framework/mode (#3185)
chore: release ionic 7.5 docs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
99bff15
to
9d9af2f
Compare
@@ -0,0 +1,236 @@ | |||
// const fetch = require('node-fetch'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this file if we don't need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can now be deleted. It can also be removed from the current build script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have asked this originally, but can you clarify why we don't need this script anymore? In main
it looks like we still use it:
Line 8 in e9c3e62
node scripts/api-ja.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, remove from main branch will not effect. Files no longer in use now.
However, this issue needs to be discussed: #3096
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
Thanks for getting this up to date! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
It took a little while, but I followed up the main branch.