{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":12256376,"defaultBranch":"main","name":"ionic-framework","ownerLogin":"ionic-team","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-08-20T23:06:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3171503?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726257987.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"014159bd5d2c55ef333ea6c9ff8c9409c9e7640c","ref":"refs/heads/tr/insert-before-error","pushedAt":"2024-09-13T20:06:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"},"commit":{"message":"fix(): dev build of stencil","shortMessageHtmlLink":"fix(): dev build of stencil"}},{"before":null,"after":"e363d20f8772e7c72013a62e5273a6186fbf0af0","ref":"refs/heads/tr/ROU-11155-backdrop-ionic-styles","pushedAt":"2024-09-13T18:52:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"},"commit":{"message":"chore(): add updated snapshots","shortMessageHtmlLink":"chore(): add updated snapshots"}},{"before":"a6f49deeb6c56b0e78b67c645843cf68d6e227ef","after":null,"ref":"refs/heads/tabs-remove-requirement","pushedAt":"2024-09-12T23:29:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"}},{"before":"ab7a0ab050935b22249c28a2a46803994ddc3bd3","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-29868-df39ceac6db6511518aed4766e6a59aa24fb53ec","pushedAt":"2024-09-12T23:29:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"df39ceac6db6511518aed4766e6a59aa24fb53ec","after":"ab7a0ab050935b22249c28a2a46803994ddc3bd3","ref":"refs/heads/main","pushedAt":"2024-09-12T23:29:22.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor(react): update tab-bar requirement on tabs (#29868)\n\nIssue number: N/A\n\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nAs mentioned in this\n[PR](https://github.com/ionic-team/ionic-docs/pull/3797), React\n`IonTabs` requires `IonTabBar` do be a child, else it doesn't render and\nthrows an error.\n\nAngular, JS, and Vue doesn't have this requirement.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\nI didn't see any reason why React does not mimic the other frameworks.\nIn order to keep consistency, I've updated the React tabs. This would\nallow `ion-tabs` and `ion-tab-bar` can be used as standalone elements as\nmentioned in the [docs](https://ionicframework.com/docs/api/tabs).\n\n- React follows the same structure as the other frameworks: `IonTabs`\ndoesn't require `IonTabBar` to be a child to render.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\nDev build: 8.3.1-dev.11726159792.1a6f49de\n\nHow to test:\n1. Create a Ionic React app through the Ionic CLI with tabs as the\nstarter\n2. Run the app\n3. Comment out the `IonTabBar`\n4. Notice that the `IonTabs` does not render\n5. Notice that there's an error in the console: \"IonTabs needs a\nIonTabBar\"\n6. Install the dev build: `npm install\n@ionic/react@8.3.1-dev.11726159792.1a6f49de`\n7. Make sure the `IonTabBar` is still commented out\n8. Verify that `IonTabs` renders\n9. Verify that there isn't an error in the console","shortMessageHtmlLink":"refactor(react): update tab-bar requirement on tabs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2522801619\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29868\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29868/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29868\">#29868</a>)"}},{"before":null,"after":"ab7a0ab050935b22249c28a2a46803994ddc3bd3","ref":"refs/heads/gh-readonly-queue/main/pr-29868-df39ceac6db6511518aed4766e6a59aa24fb53ec","pushedAt":"2024-09-12T23:18:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor(react): update tab-bar requirement on tabs (#29868)\n\nIssue number: N/A\n\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nAs mentioned in this\n[PR](https://github.com/ionic-team/ionic-docs/pull/3797), React\n`IonTabs` requires `IonTabBar` do be a child, else it doesn't render and\nthrows an error.\n\nAngular, JS, and Vue doesn't have this requirement.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\nI didn't see any reason why React does not mimic the other frameworks.\nIn order to keep consistency, I've updated the React tabs. This would\nallow `ion-tabs` and `ion-tab-bar` can be used as standalone elements as\nmentioned in the [docs](https://ionicframework.com/docs/api/tabs).\n\n- React follows the same structure as the other frameworks: `IonTabs`\ndoesn't require `IonTabBar` to be a child to render.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\nDev build: 8.3.1-dev.11726159792.1a6f49de\n\nHow to test:\n1. Create a Ionic React app through the Ionic CLI with tabs as the\nstarter\n2. Run the app\n3. Comment out the `IonTabBar`\n4. Notice that the `IonTabs` does not render\n5. Notice that there's an error in the console: \"IonTabs needs a\nIonTabBar\"\n6. Install the dev build: `npm install\n@ionic/react@8.3.1-dev.11726159792.1a6f49de`\n7. Make sure the `IonTabBar` is still commented out\n8. Verify that `IonTabs` renders\n9. Verify that there isn't an error in the console","shortMessageHtmlLink":"refactor(react): update tab-bar requirement on tabs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2522801619\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29868\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29868/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29868\">#29868</a>)"}},{"before":"54003558aa20cfa9afa489809e11766ae62adb2b","after":"e4bc725d54b76b554dca2544f8817664c31a0d00","ref":"refs/heads/tr/revert-react-output-target","pushedAt":"2024-09-12T21:41:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"},"commit":{"message":"chore(): add version todo comments","shortMessageHtmlLink":"chore(): add version todo comments"}},{"before":"3e9953412a34bb5b8ff9b7ce28951a7f33100d69","after":"5a1af41172e83bea3f986265769d37c4f94c9461","ref":"refs/heads/app-move-initialize","pushedAt":"2024-09-12T20:13:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"refactor(app): move focus utils to global","shortMessageHtmlLink":"refactor(app): move focus utils to global"}},{"before":null,"after":"3e9953412a34bb5b8ff9b7ce28951a7f33100d69","ref":"refs/heads/app-move-initialize","pushedAt":"2024-09-12T18:17:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"refactor(app): move the majority of the bootstrapping to global","shortMessageHtmlLink":"refactor(app): move the majority of the bootstrapping to global"}},{"before":"cdbab6fd4a1ab60d9c72dfeb122383767ab10b87","after":null,"ref":"refs/heads/ROU-11138","pushedAt":"2024-09-12T17:46:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"}},{"before":"df39ceac6db6511518aed4766e6a59aa24fb53ec","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-29865-35b1a459294657b609f683457e71babd4673a3a8","pushedAt":"2024-09-12T17:46:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"35b1a459294657b609f683457e71babd4673a3a8","after":"df39ceac6db6511518aed4766e6a59aa24fb53ec","ref":"refs/heads/main","pushedAt":"2024-09-12T17:46:45.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix(react, vue): add default value for navManager on tabs (#29865)\n\nIssue number: N/A\n\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nReact: Refreshes the app upon a tab button press and returns to the\nfirst tab content.\nVue: Does not render the tabs when the app doesn't use a router at all\nbecause of `ionRouter` not being defined.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\n- React: Users can press on the tab button without having the app\nrefresh and displays the associated tab content.\n- Vue: Renders the tabs when router is not present.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\nDev build: 8.3.1-dev.11726094383.1cdbab6f\n\nHow to test:\nI recommend using the playgrounds in the Ionic Framework docs repo since\nthose playgrounds are setup to not have any routers at a high level.\n\n1. Navigate to the [basic usage\nsection](https://ionic-docs-git-rou-11138-ionic1.vercel.app/docs/api/tabs#basic-usage)\n2. Select React\n3. Open the StackBlitz example\n4. Click on any tab button\n5. Notice that the app refreshes and returns to the first tab content\n6. Install the dev build: `npm install\n@ionic/react@8.3.1-dev.11726094383.1cdbab6f`\n7. Verify that the app doesn't refresh and reset the content after\nclicking on any tab button\n8. Navigate to the [basic usage\nsection](https://ionic-docs-git-rou-11138-ionic1.vercel.app/docs/api/tabs#basic-usage)\n9. Select Vue\n10. Open the StackBlitz example\n11. Notice that tabs doesn't render\n12. Open the console and notice that there's an error `ionRouter is\nundefined`\n13. Install the dev build: `npm install\n@ionic/vue@8.3.1-dev.11726094383.1cdbab6f`\n14. Verify that it renders\n15. Verify that the console no longer shows the error","shortMessageHtmlLink":"fix(react, vue): add default value for navManager on tabs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2520649542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29865\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29865/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29865\">#29865</a>)"}},{"before":null,"after":"df39ceac6db6511518aed4766e6a59aa24fb53ec","ref":"refs/heads/gh-readonly-queue/main/pr-29865-35b1a459294657b609f683457e71babd4673a3a8","pushedAt":"2024-09-12T17:35:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix(react, vue): add default value for navManager on tabs (#29865)\n\nIssue number: N/A\n\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nReact: Refreshes the app upon a tab button press and returns to the\nfirst tab content.\nVue: Does not render the tabs when the app doesn't use a router at all\nbecause of `ionRouter` not being defined.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\n- React: Users can press on the tab button without having the app\nrefresh and displays the associated tab content.\n- Vue: Renders the tabs when router is not present.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\nDev build: 8.3.1-dev.11726094383.1cdbab6f\n\nHow to test:\nI recommend using the playgrounds in the Ionic Framework docs repo since\nthose playgrounds are setup to not have any routers at a high level.\n\n1. Navigate to the [basic usage\nsection](https://ionic-docs-git-rou-11138-ionic1.vercel.app/docs/api/tabs#basic-usage)\n2. Select React\n3. Open the StackBlitz example\n4. Click on any tab button\n5. Notice that the app refreshes and returns to the first tab content\n6. Install the dev build: `npm install\n@ionic/react@8.3.1-dev.11726094383.1cdbab6f`\n7. Verify that the app doesn't refresh and reset the content after\nclicking on any tab button\n8. Navigate to the [basic usage\nsection](https://ionic-docs-git-rou-11138-ionic1.vercel.app/docs/api/tabs#basic-usage)\n9. Select Vue\n10. Open the StackBlitz example\n11. Notice that tabs doesn't render\n12. Open the console and notice that there's an error `ionRouter is\nundefined`\n13. Install the dev build: `npm install\n@ionic/vue@8.3.1-dev.11726094383.1cdbab6f`\n14. Verify that it renders\n15. Verify that the console no longer shows the error","shortMessageHtmlLink":"fix(react, vue): add default value for navManager on tabs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2520649542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29865\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29865/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29865\">#29865</a>)"}},{"before":null,"after":"54003558aa20cfa9afa489809e11766ae62adb2b","ref":"refs/heads/tr/revert-react-output-target","pushedAt":"2024-09-12T16:36:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"},"commit":{"message":"fix(react): revert react output target version","shortMessageHtmlLink":"fix(react): revert react output target version"}},{"before":null,"after":"a6f49deeb6c56b0e78b67c645843cf68d6e227ef","ref":"refs/heads/tabs-remove-requirement","pushedAt":"2024-09-12T16:03:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(react): update tabbar requirement on tabs","shortMessageHtmlLink":"refactor(react): update tabbar requirement on tabs"}},{"before":"039bf6a90a7c589b0b4d5a8b740282b156e1f7a6","after":null,"ref":"refs/heads/tr/ROU-11154-modal-shape","pushedAt":"2024-09-12T02:30:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"}},{"before":"1841b59e445716ce3017e2c78510721c045c5090","after":"60e6b3143eaaf39bab2495d99a3a25289b0442cb","ref":"refs/heads/next","pushedAt":"2024-09-12T02:30:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"},"commit":{"message":"feat(modal): add shape prop & styling for ionic theme (#29853)\n\nIssue number: internal\r\n\r\n---------\r\n\r\n<!-- Please do not submit updates to dependencies unless it fixes an\r\nissue. -->\r\n\r\n<!-- Please try to limit your pull request to one type (bugfix, feature,\r\netc). Submit multiple pull requests if needed. -->\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying. -->\r\n\r\nNo shape prop or ionic theme styling\r\n\r\n## What is the new behavior?\r\n<!-- Please describe the behavior or changes that are being added by\r\nthis PR. -->\r\n\r\n- Adds `shape` prop to `ion-modal`\r\n- Adds styling for shape in ionic theme\r\n\r\n## Does this introduce a breaking change?\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\n<!--\r\n  If this introduces a breaking change:\r\n1. Describe the impact and migration path for existing applications\r\nbelow.\r\n  2. Update the BREAKING.md file with the breaking change.\r\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\r\nSee\r\nhttps://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer\r\nfor more information.\r\n-->\r\n\r\n\r\n## Other information\r\n\r\n<!-- Any other information that is important to this PR such as\r\nscreenshots of how the component looks before and after the change. -->","shortMessageHtmlLink":"feat(modal): add shape prop &amp; styling for ionic theme (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2517307090\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29853\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29853/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29853\">#29853</a>)"}},{"before":"641303cc7e08acc576dab3724be72abcd3373daf","after":"cdbab6fd4a1ab60d9c72dfeb122383767ab10b87","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T21:33:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(tabs): use default value for navManager","shortMessageHtmlLink":"refactor(tabs): use default value for navManager"}},{"before":null,"after":"09589dd79fe46e9ad8c08c56a28e9bcce3b3db96","ref":"refs/heads/ion-page-remove-class","pushedAt":"2024-09-11T21:11:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"brandyscarney","name":"Brandy Carney","path":"/brandyscarney","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6577830?s=80&v=4"},"commit":{"message":"test(many): remove ion-page wrappers","shortMessageHtmlLink":"test(many): remove ion-page wrappers"}},{"before":"94bcb8eb9f28a7bae0a9f48edc550be445c81f46","after":"641303cc7e08acc576dab3724be72abcd3373daf","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T21:10:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(tabs): prevent app from refreshing","shortMessageHtmlLink":"refactor(tabs): prevent app from refreshing"}},{"before":"60288c7f3b01fa1da78a12988e687881b8573958","after":"94bcb8eb9f28a7bae0a9f48edc550be445c81f46","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T20:50:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(tabs): add checks for navManager on button","shortMessageHtmlLink":"refactor(tabs): add checks for navManager on button"}},{"before":"beb2c260677b8122eac109ed61d7d2cb9d8a1a58","after":"60288c7f3b01fa1da78a12988e687881b8573958","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T20:28:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(tabs): add another check","shortMessageHtmlLink":"refactor(tabs): add another check"}},{"before":"33d3414bc08856e61697d4c84b9874dda20ab45f","after":"beb2c260677b8122eac109ed61d7d2cb9d8a1a58","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T20:09:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"Merge branch 'main' of github.com:ionic-team/ionic-framework into ROU-11138","shortMessageHtmlLink":"Merge branch 'main' of github.com:ionic-team/ionic-framework into ROU…"}},{"before":"d8ced56371df28f9cd301a062e2dfd397af2d2fc","after":"33d3414bc08856e61697d4c84b9874dda20ab45f","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T20:01:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"refactor(tabs): update if statement check","shortMessageHtmlLink":"refactor(tabs): update if statement check"}},{"before":null,"after":"d8ced56371df28f9cd301a062e2dfd397af2d2fc","ref":"refs/heads/ROU-11138","pushedAt":"2024-09-11T19:58:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"},"commit":{"message":"fix(tabs): add check for navManager","shortMessageHtmlLink":"fix(tabs): add check for navManager"}},{"before":"00c00d69beecd95e9f7adabaf6c9114307237be2","after":null,"ref":"refs/heads/FW-2873","pushedAt":"2024-09-11T16:50:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thetaPC","name":"Maria Hutt","path":"/thetaPC","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13530427?s=80&v=4"}},{"before":"35b1a459294657b609f683457e71babd4673a3a8","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-29241-f4ee2bbfc4768578dee9e392a5bf267e3ead5ec2","pushedAt":"2024-09-11T16:50:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"f4ee2bbfc4768578dee9e392a5bf267e3ead5ec2","after":"35b1a459294657b609f683457e71babd4673a3a8","ref":"refs/heads/main","pushedAt":"2024-09-11T16:50:50.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix(range): disable scroll when range is being dragged (#29241)\n\nIssue number: internal\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nThere are a few tests that were disabled due to being flaky from\ngestures.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\nWhile fixing the tests, I found a bug that the scroll was never being\ndisabled on scroll. Additionally, we were not taking into account that a\ncustom scroll target could be used so it was never disabled either.\n\n- Fixed the flaky tests.\n- Content doesn't scroll when range is being dragged.\n- Content can be either `ion-content` or a custom scroll target.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\n[Preview for\n`ion-content`](https://ionic-framework-git-fw-2873-ionic1.vercel.app/src/components/range/test/scroll)\n[Preview for custom scroll\ntarget](https://ionic-framework-git-fw-2873-ionic1.vercel.app/src/components/range/test/scroll-target)\n\nHow to test:\n1. Open either of the previews\n2. Render the screen with the device simulator from the browser\n3. Verify that you can scroll the page\n4. Drag the range but don't let go\n5. Verify that you cannot scroll the page\n6. Repeat steps 2-5 with the other preview","shortMessageHtmlLink":"fix(range): disable scroll when range is being dragged (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2216071672\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29241\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29241/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29241\">#29241</a>)"}},{"before":null,"after":"35b1a459294657b609f683457e71babd4673a3a8","ref":"refs/heads/gh-readonly-queue/main/pr-29241-f4ee2bbfc4768578dee9e392a5bf267e3ead5ec2","pushedAt":"2024-09-11T16:39:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix(range): disable scroll when range is being dragged (#29241)\n\nIssue number: internal\n---------\n\n<!-- Please do not submit updates to dependencies unless it fixes an\nissue. -->\n\n<!-- Please try to limit your pull request to one type (bugfix, feature,\netc). Submit multiple pull requests if needed. -->\n\n## What is the current behavior?\n<!-- Please describe the current behavior that you are modifying. -->\n\nThere are a few tests that were disabled due to being flaky from\ngestures.\n\n## What is the new behavior?\n<!-- Please describe the behavior or changes that are being added by\nthis PR. -->\n\nWhile fixing the tests, I found a bug that the scroll was never being\ndisabled on scroll. Additionally, we were not taking into account that a\ncustom scroll target could be used so it was never disabled either.\n\n- Fixed the flaky tests.\n- Content doesn't scroll when range is being dragged.\n- Content can be either `ion-content` or a custom scroll target.\n\n## Does this introduce a breaking change?\n\n- [ ] Yes\n- [x] No\n\n<!--\n  If this introduces a breaking change:\n1. Describe the impact and migration path for existing applications\nbelow.\n  2. Update the BREAKING.md file with the breaking change.\n3. Add \"BREAKING CHANGE: [...]\" to the commit description when merging.\nSee\nhttps://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer\nfor more information.\n-->\n\n\n## Other information\n\n<!-- Any other information that is important to this PR such as\nscreenshots of how the component looks before and after the change. -->\n\n[Preview for\n`ion-content`](https://ionic-framework-git-fw-2873-ionic1.vercel.app/src/components/range/test/scroll)\n[Preview for custom scroll\ntarget](https://ionic-framework-git-fw-2873-ionic1.vercel.app/src/components/range/test/scroll-target)\n\nHow to test:\n1. Open either of the previews\n2. Render the screen with the device simulator from the browser\n3. Verify that you can scroll the page\n4. Drag the range but don't let go\n5. Verify that you cannot scroll the page\n6. Repeat steps 2-5 with the other preview","shortMessageHtmlLink":"fix(range): disable scroll when range is being dragged (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2216071672\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ionic-team/ionic-framework/issues/29241\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ionic-team/ionic-framework/pull/29241/hovercard\" href=\"https://github.com/ionic-team/ionic-framework/pull/29241\">#29241</a>)"}},{"before":"158ff13c50e303e3a2e6753a727fd581421b898f","after":null,"ref":"refs/heads/tr/sheet-modal-snapshots","pushedAt":"2024-09-11T15:31:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"tanner-reits","name":"Tanner Reits","path":"/tanner-reits","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47483144?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QyMDowNjoyNy4wMDAwMDBazwAAAAS12WlN","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xM1QyMDowNjoyNy4wMDAwMDBazwAAAAS12WlN","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMVQxNTozMToyMS4wMDAwMDBazwAAAASzYXqw"}},"title":"Activity · ionic-team/ionic-framework"}