Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.6] closeSlidingItems() was removed #15378

Closed
brandyscarney opened this issue Aug 29, 2018 · 3 comments
Closed

[4.0.0-beta.6] closeSlidingItems() was removed #15378

brandyscarney opened this issue Aug 29, 2018 · 3 comments

Comments

@brandyscarney
Copy link
Member

We removed closeSlidingItems() in this commit: 1d46973#diff-18371551b2381093b54fbcd55f8ebe87L50

It needs to be
A) documented in breaking changes with the new way or
B) added back because this is breaking the conference app

Also we should add some documentation on the new way to use the methods

@ionitron-bot ionitron-bot bot added triage and removed triage labels Aug 29, 2018
@brandyscarney
Copy link
Member Author

cc @manucorporat

@manucorporat
Copy link
Contributor

manucorporat commented Aug 30, 2018

  @Element() el!: HTMLElement;

  @Method()
  async closeSlidingItems(): Promise<boolean> {
    const item = this.el.querySelector('ion-item-sliding');
    if (item && item.closeOpened) {
      return item.closeOpened();
    }
    return false;
  }

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 29, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants