-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: react build breaks on upgrade to 17 - compiler options set to react-jsx and this is not recognized #22537
Comments
Thanks for the issue! This issue has been labeled as Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed. If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue. For a guide on how to create a good reproduction, see our Contributing Guide. |
Repo: https://github.com/peterennis/tutorial-photo-gallery-react Note: If I run
|
@elylucas repro provided above |
Hi @peterennis, I think this might be an issue that was recently fixed in react-scripts@4.0.1 (see facebook/create-react-app#9868). Could you try Thanks |
Also, for that error in VSCode, make sure you are using the project version (should be 4.1.2 or greater, if not upgrade TS) and not the version that comes with VSCode. |
@elylucas |
Thanks for the issue! The remaining issue here appears to be related to Jest's lack of support for ES Modules. We have an open issue at #24026 which is being used to track how to account for this in Ionic apps. Until Jest ships support for ES Modules , we recommend using We will post any updates in #24026. Thanks! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[ ] 4.x
[x] 5.x
Current behavior:
Expected behavior:
Steps to reproduce:
upgrade Ionic React tutorial demo to use React 17
Related code:
Other information:
Ionic info:
Ref: facebook/create-react-app#9429
The text was updated successfully, but these errors were encountered: