Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): export DatetimeHighlightStyle #27360

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(types): export DatetimeHighlightStyle #27360

merged 1 commit into from
May 4, 2023

Conversation

sean-perkins
Copy link
Contributor

Issue number: Resolves #27353

What is the current behavior?

DatetimeHighlightStyle is not automatically exported from @ionic/core, since the type is not directly referenced on a prop.

What is the new behavior?

  • Manually exports DatetimeHighlightStyle to consumers

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented May 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label May 3, 2023
@sean-perkins sean-perkins mentioned this pull request May 3, 2023
Closed
3 tasks
@sean-perkins sean-perkins marked this pull request as ready for review May 3, 2023 15:30
@sean-perkins sean-perkins requested a review from a team as a code owner May 3, 2023 15:30
thetaPC
thetaPC approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit a37cdb1 May 4, 2023
@sean-perkins sean-perkins deleted the FW-4239 branch May 4, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: missing export of DatetimeHighlightStyle
2 participants
@sean-perkins @thetaPC