Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): schematics account for new theme files #29185

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 19, 2024

Issue number: Internal


What is the current behavior?

While doing other work I noticed that the Angular schematics still reference the old dark theme.

What is the new behavior?

  • The Angular schematics now import the new dark theme found in Ionic v8.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the base branch from main to feature-8.0 March 19, 2024 20:06
@github-actions github-actions bot added the package: angular @ionic/angular package label Mar 19, 2024
@liamdebeasi liamdebeasi changed the title Angular schematic v8 fix(angular): schematics account for new theme files Mar 19, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review March 19, 2024 20:39
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi merged commit b0a10df into feature-8.0 Mar 20, 2024
42 checks passed
@liamdebeasi liamdebeasi deleted the angular-schematic-v8 branch March 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants