-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): activated outline button in toolbar no longer blends into background on MD dark mode #29216
Conversation
…ound on dark mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the issue has been fixed.
However, there are a few tests that are not related to the issue. Let's keep this PR specific to it and open a new PR that introduces these test changes.
…ound on dark mode
@amandaejohnston Is this ready for review? It's marked as draft. |
@thetaPC No, the screenshots haven't been updated yet here. Running the job causes them to be updated off of |
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The toolbar `basic` test only checks light theme. Dark theme coverage is required to test against the bug fixed in #29216. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Dark theme coverage added. This required converting the test to `page.setContent` instead of `page.goto`, so I went ahead and split the captured toolbars into multiple tests, including some cleanup of the test content. Since this included changes across many different tests, even ones not strictly related to the bug, this work has been split into a separate PR. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Well, suddenly glad I split the test changes out the way I did, because it made me realize I regressed the styling on iOS 😆 |
This reverts commit 4d188c2.
@thetaPC This is ready for review again 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment request
Issue number: N/A
What is the current behavior?
When using an outline-style button in a toolbar on
md
dark mode, the activated style causes the button to become invisible.Steps to repro in
main
:css-variables
themes test to use the latest dark theme styles (at least for v7) by replacing the contents of this file with the styles from the docs.themes/test/css-variables/index.html
.What is the new behavior?
ios
mode, but had to be flipped formd
, so I pulled the relevant styles into the mode-specific stylesheets.Changes to the toolbar test were split into a separate PR to keep this one clean and ensure the screenshot changes can be reviewed more effectively: #29231
Does this introduce a breaking change?
Other information