Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): do not overwrite id set in htmlAttributes #29708

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

mikelhamer
Copy link
Contributor

Issue number: resolves #29704


What is the current behavior?

Setting the id of an alert via htmlAttributes doesn't work due to it being overwritten by the overlay id.

What is the new behavior?

Setting the id of an alert via htmlAttributes works.

Does this introduce a breaking change?

  • Yes
  • No

Other information

First time PR, long time fan. Please let me know if I missed any of the contributing guidelines, happy to change anything!

@mikelhamer mikelhamer requested a review from a team as a code owner July 12, 2024 23:41
@mikelhamer mikelhamer requested a review from BenOsodrac July 12, 2024 23:41
Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 2:22pm

@github-actions github-actions bot added the package: core @ionic/core package label Jul 12, 2024
@sean-perkins sean-perkins changed the title fix(alert): dont overwrite id set in htmlAttributes fix(alert): do not overwrite id set in htmlAttributes Jul 15, 2024
Copy link
Contributor Author

@mikelhamer mikelhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. My commit message is bad here. Should just say something like "eslint fix". I didn't realize doing that also changed other things besides adding the semicolon at first

@sean-perkins
Copy link
Contributor

@mikelhamer the individual commit messages will not matter here 👍 the Ionic Framework repository uses squash commits and uses the PR subject line as the title and the body of the PR as the message.

@sean-perkins sean-perkins requested review from brandyscarney and thetaPC and removed request for BenOsodrac July 15, 2024 14:36
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes function as expected in my testing. Thank you for your contribution to Ionic Framework!

For the dev team: This issue applies to more than the ion-alert. I think to deliver value/resolve the issue experienced by Mikel we could merge this and split the original issue to track the other overlays impacted. Then the dev team could either address those or the community could assist in fixing the remaining overlays.

@brandyscarney brandyscarney added this pull request to the merge queue Jul 15, 2024
Merged via the queue into ionic-team:main with commit 1295ced Jul 15, 2024
47 checks passed
@mikelhamer
Copy link
Contributor Author

Thank you! I'd be glad to help with the remaining overlays once the original issue has been split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Alerts override id assigned through htmlAttributes
3 participants