-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlays): do not overwrite id set in htmlAttributes #29722
Conversation
# Conflicts: # core/src/components/alert/test/alert-id.spec.tsx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@sean-perkins I've created this PR to fix #29712 , but something I noticed is that the overlay ID is being used in the picker-legacy component, but not in the the new picker component. |
@mikelhamer great observation, you are correct in your current implementation pattern. |
Awesome! The more you know... 🌈 ⭐️ |
…ot overwritten when it has an integer value of 0 Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏 thanks for knocking these out!
My pleasure! It was an awesome learning experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Great work. 🎉
Thank you! 🚀 |
Issue number: resolves #29712
What is the current behavior?
In every type of overlay, the auto incremented overlay id is overwriting any id set in htmlAttributes.
What is the new behavior?
The id in htmlAttributes now takes precedence.
Does this introduce a breaking change?
Other information