fix(vue): pass router-link value to href to properly render clickable elements #29745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
force-pushed
the
ROU-10977
branch
from
edc4e6c
to
8e67945
Compare
thetaPC
reviewed
Aug 5, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Ionic Framework Vue components using
router-linkdo not apply anhrefproperty which causes components to renderdivorbuttonelements when they should render ana. This is inconsistent with the way Angular and Vue handle router link.What is the new behavior?
Updates
@stencil/vue-output-targetto latest which adds the code from the following PR: ionic-team/stencil-ds-output-targets#446The update in vue output target checks if
router-linkandnavManagerare defined so this fix only applies to Ionic Framework components. If both are defined then it adds thehrefproperty to the element with the value ofrouter-link.Does this introduce a breaking change?
Other information
Dev build:
8.2.7-dev.11722629362.1ac136c4