-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio): display as block when justify or alignment properties are defined #29801
Merged
+120
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
force-pushed
the
ROU-11044
branch
from
August 26, 2024 17:05
7d0d892
to
66ec873
Compare
2 tasks
thetaPC
requested changes
Aug 27, 2024
thetaPC
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BenOsodrac
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
When adding the
justify
oralignment
property to anion-radio
it does not change the design because the radio is displayed inline.What is the new behavior?
This is doing the same thing as #29783
display
property toblock
when thejustify
oralignment
property is set.justify-content
style tospace-between
so that a radio withwidth: 100%
set withoutjustify
oralignment
set will still have the same defaultlabel-placement
e2e test to remove the explicit width as setting the property will make them full-widthlabel-placement
e2e test of labels that do not havejustify
set but usewidth: 100%
to ensure they are working as expected without itlabel-placement
e2e test of a long label that usesjustify
to ensure it still wraps properly (this existed in the checkbox test but not radio)Does this introduce a breaking change?
Other information