fix(datetime): display today's date and time when value is an empty string #29839
+34
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29669
What is the current behavior?
Setting
value
to an empty string on<ion-datetime>
renders a May 2021 calendar:What is the new behavior?
Show the month and time for today's date when value is an empty string. This matches how a native
input
withtype="datetime-local"
works.Does this introduce a breaking change?
Other information
This can be tested by removing my fix in
datetime.tsx
and running the e2e test for Datetime:The
should display today's date and time when value is an empty string
test should fail.Alternatively, you can add a datetime with
value=""
and see the calendar before & after my fix.