-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): revert react output target version #29869
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
renovate.json5
Outdated
{ | ||
matchPackageNames: ["@stencil/react-output-target"], | ||
matchFileNames: [ | ||
"core/package.json" | ||
], | ||
allowedVersions: ["<=0.5.3"] | ||
}, | ||
{ | ||
matchPackageNames: ["@stencil/core"], | ||
matchFileNames: [ | ||
"core/package.json" | ||
], | ||
allowedVersions: ["<=4.20.0"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work to prevent these packages from updating, but hard to know until it merges and we let Renovate run 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also gonna create tasks for these respective issues so I'll add a comment with each of those task numbers once I have them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, verified that the React test build still works and that both bugs from stencil-ds-output-targets are resolved.
However, I couldn't replicate this issue. I highly suggest asking the community to see if the dev build fixes their issue. If it does then we can change the PR description to resolve the issue: Issue number: ionic-team/stencil-ds-output-targets#476, ionic-team/stencil-ds-output-targets#475, #29848
to Issue number: ionic-team/stencil-ds-output-targets#476, ionic-team/stencil-ds-output-targets#475, resolves #29848
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed both of the linked issues in stencil-ds-output-targets
are resolved by the dev build. 👍
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> In v0.6.0 of the [React output target](https://www.npmjs.com/package/@stencil/react-output-target), the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes. <!-- Please describe the behavior or changes that are being added by this PR. --> - Reverts many of the changes from #29782 to downgrade the React output target package to the last stable version (v0.5.3) - Downgrades the version of Stencil to v4.20.0 (due to ionic-team/stencil#5983 causing problems with the downgraded output target) - Pins these versions and prevents Renovate from attempting to upgrade until the associated issues are resolved - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build for this version: `8.3.1-dev.11726167750.15400355` I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848
What is the current behavior?
In v0.6.0 of the React output target, the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build for this version:
8.3.1-dev.11726167750.15400355
I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476