Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add missing 'compareWith' input to standalone ion-radio-group #29870

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ebarooni
Copy link
Contributor

Issue number: resolves #29826


What is the current behavior?

When using compareWith on ion-radio-group in Ionic Angular Standalone the following error is thrown:

NG8002: Can't bind to 'compareWith' since it isn't a known property of 'ion-radio-group'.

What is the new behavior?

  • compareWith on ion-radio-group in Angular Standalone is available

Does this introduce a breaking change?

  • Yes
  • No

@ebarooni ebarooni requested a review from a team as a code owner September 12, 2024 20:04
@ebarooni ebarooni requested a review from joselrio September 12, 2024 20:04
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 8:07pm

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and confirmed the fix

@tanner-reits tanner-reits changed the title fix(angular, radioGroup): add missing 'compareWith' to ion-radio-group fix(angular): add missing 'compareWith' input to standalone ion-radio-group Oct 22, 2024
@tanner-reits tanner-reits added this pull request to the merge queue Oct 22, 2024
Merged via the queue into ionic-team:main with commit 47ba703 Oct 22, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: RadioGroup "compareWith" not available in Angular Standalone Components
2 participants