Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): add support for passing role to close events #29954

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 21, 2024

Issue number: internal


What is the current behavior?

The menu ionWillClose and ionDidClose events do not emit any details.

What is the new behavior?

  • Adds the MenuCloseEventDetail interface which includes an optional role property
  • The ionWillClose and ionDidClose emit the role property for the following scenarios:
    • A role of 'gesture' when dragging the menu closed
    • A role of 'backdrop' when clicking on the backdrop to close the menu
    • A role of 'backdrop' when the the menu is closed using the escape key
    • A role of undefined when the menu is closed from a button inside of the menu

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 7:53pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package labels Oct 21, 2024
@brandyscarney brandyscarney marked this pull request as ready for review October 21, 2024 19:57
@brandyscarney brandyscarney requested a review from a team as a code owner October 21, 2024 19:57
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brandyscarney brandyscarney merged commit 12ff29c into feature-8.4 Oct 22, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-11148 branch October 22, 2024 14:55
tanner-reits pushed a commit that referenced this pull request Nov 4, 2024
- Adds the `MenuCloseEventDetail` interface which includes an optional `role` property
- The `ionWillClose` and `ionDidClose` emit the `role` property for the following scenarios:
  - A role of `'gesture'` when dragging the menu closed
- A role of `'backdrop'` when clicking on the backdrop to close the menu
- A role of `'backdrop'` when the the menu is closed using the escape key
- A role of `undefined` when the menu is closed from a button inside of
the menu
tanner-reits pushed a commit that referenced this pull request Nov 4, 2024
- Adds the `MenuCloseEventDetail` interface which includes an optional `role` property
- The `ionWillClose` and `ionDidClose` emit the `role` property for the following scenarios:
  - A role of `'gesture'` when dragging the menu closed
- A role of `'backdrop'` when clicking on the backdrop to close the menu
- A role of `'backdrop'` when the the menu is closed using the escape key
- A role of `undefined` when the menu is closed from a button inside of
the menu
tanner-reits pushed a commit that referenced this pull request Nov 4, 2024
- Adds the `MenuCloseEventDetail` interface which includes an optional `role` property
- The `ionWillClose` and `ionDidClose` emit the `role` property for the following scenarios:
  - A role of `'gesture'` when dragging the menu closed
- A role of `'backdrop'` when clicking on the backdrop to close the menu
- A role of `'backdrop'` when the the menu is closed using the escape key
- A role of `undefined` when the menu is closed from a button inside of
the menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants