fix(overlays): do not hide root when toast appears #29962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: stemmed from #29773
What is the current behavior?
Certain Chrome and Edge versions (confirmed: Chrome v127, v128, v129 and Edge v127) would indicate that certain elements have an accessibility violation:
This issue happens when a toast appears and the users clicks on any element that is not related to toast. This is due to the main content having an
aria-hidden
so users should not to be able to interact with any of those elements. This isn't an issue when an overlay uses a backdrop, likeion-alert
because the backdrop prevents a user from interacting with those elements.What is the new behavior?
aria-hidden
. This aligns with accessibility guidelines. I also verified with other Framework, MD states "Don't trap focus in the snackbar. Users should be able to freely navigate in and out."Does this introduce a breaking change?
Other information
Dev build:
8.3.4-dev.11729879684.1ea28919
npm install @ionic/angular@8.3.4-dev.11729879684.1ea28919