Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlays): hide the focus trap div from screen readers #29970

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 25, 2024

Issue number: resolves #29858


What is the current behavior?

When swiping between elements using Android TalkBack, a green box is shown for certain overlays and it gains focus at the beginning and end of those overlays:

Screenshot 2024-10-25 at 2 44 45 PM

What is the new behavior?

The aria-hidden attribute is now added to the focus trap divs to hide them from screen readers, without preventing these divs from trapping keyboard focus.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.3.4-dev.11729882231.1b2e7f13

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:49pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 25, 2024
@brandyscarney brandyscarney marked this pull request as ready for review October 28, 2024 16:19
@brandyscarney brandyscarney requested a review from a team as a code owner October 28, 2024 16:19
@brandyscarney brandyscarney requested a review from gnbm October 28, 2024 16:19
@brandyscarney brandyscarney requested a review from thetaPC October 28, 2024 19:55
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit c3b58f1 Oct 29, 2024
61 checks passed
@brandyscarney brandyscarney deleted the ROU-11313 branch October 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Alerts/dialogs have unnecessary focus boxes with no description when using Android TalkBack
3 participants