Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic2 ion-item with ion-select lost className ng-* #8082

Closed
rehiy opened this issue Sep 14, 2016 · 3 comments
Closed

Ionic2 ion-item with ion-select lost className ng-* #8082

rehiy opened this issue Sep 14, 2016 · 3 comments

Comments

@rehiy
Copy link

rehiy commented Sep 14, 2016

here, the ion-item have not include the className "ng-valid ng-touched ng-dirty".

<ion-item class="item item-select">
    <div class="item-inner">
      <div class="input-wrapper">
        <ion-select class="ng-valid ng-touched ng-dirty">
         .........
        </ion-select>
      </div>
    </div>
</ion-item>

howerver, i think we shoude do it like the ion-input.

<ion-item class="item item-input ng-pristine ng-invalid ng-touched">
    <div class="item-inner">
      <div class="input-wrapper">
        <ion-input name="password" class="ng-pristine ng-invalid ng-touched">
        </ion-input>
        ........
      </div>
    </div>
</ion-item>
@jgw96
Copy link
Contributor

jgw96 commented Sep 15, 2016

Hello, thanks for opening an issue with us! Unfortunately, I am not fully understanding the issue here. Are you saying that ion-select is not getting the correct classes? From your code snippet it seems like it is? Thanks!

@jgw96 jgw96 added needs: reply the issue needs a response from the user and removed platform:ios labels Sep 15, 2016
@rehiy
Copy link
Author

rehiy commented Sep 15, 2016

Yes, the ion-select do not sync the ng-* from ion-select to ion-item.

it should be

<ion-item class="item item-select ng-valid ng-touched ng-dirty">
    <ion-select class="ng-valid ng-touched ng-dirty">

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Sep 15, 2016
@rehiy rehiy changed the title Ionic2 ion-select parent ion-item className miss some value Ionic2 ion-select parent ion-item className miss ng-* Sep 15, 2016
@jgw96 jgw96 removed the alert label Sep 15, 2016
@rehiy rehiy changed the title Ionic2 ion-select parent ion-item className miss ng-* Ionic2 ion-item with ion-select lost className ng-* Sep 15, 2016
@brandyscarney
Copy link
Member

Closing as a duplicate of #6040. Thanks!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants