Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-item does not show line if it is in ion-card-content #9198

Closed
mburger81 opened this issue Nov 17, 2016 · 10 comments
Closed

ion-item does not show line if it is in ion-card-content #9198

mburger81 opened this issue Nov 17, 2016 · 10 comments

Comments

@mburger81
Copy link
Contributor

Short description of the problem:

I tried to create a ion-list in an ion-card, but the ion-item does not show the expected line between the items if the ion-list is encapsulated in an ion-card.

What behavior are you expecting?

I'don't know if this is expected but I didn't found nothing in the documentation, and that's not the thing I expecting.

Steps to reproduce:
You can see here a plnkr with RC.2 which shows the two difference from a ion-list in and out of a ion-card
http://plnkr.co/edit/v8P1oV?p=preview

This is the result:

image

@brandyscarney
Copy link
Member

Thanks for the issue! This is by design to match the Material Design docs. See the following image of a list in a card:

and the docs can be found here: https://material.google.com/components/cards.html#

@mburger81
Copy link
Contributor Author

Hi @brandyscarney but in the docs you can also find some use cases like this.
Isn't this a card with a list which contains a divider in it?

image

@basvdijk
Copy link

basvdijk commented Mar 2, 2017

I am running into the same problem. It would be nice if this was a attribute you could set instead of being forced to have no lines :)

@judgewest2000
Copy link

Using css you can throw these in...

https://forum.ionicframework.com/t/list-dividers-lines-in-cards/91734/5

@WhatsThatItsPat
Copy link

This is by design to match the Material Design docs.

I'd like to question this decision as well. As shown by @mburger81 above, there are examples where lists in cards have lines, so it doesn't look like an actual MD spec. And even in the weather cards example above, the bottom "full report" item shows a separating line.

Since we have the no-lines attribute available to us, it should be up to the dev if that's the design we want to match.

Alternatively, you could add a force-lines, attribute but that feels cumbersome. I think it would be better for items to work the same way by default.

@brandyscarney
Copy link
Member

Reopening to revisit, cc @bensperry @jgw96

@brandyscarney brandyscarney reopened this Jul 17, 2017
@judgewest2000
Copy link

I concur with @PatrickMcD - would prefer to have unless omitted specifically with no-lines

@lexyfeito
Copy link

any news on this, i having the same issue.. thank you

@JamboBuenna
Copy link

Any updates?

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 13, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants