From 805910280d450e7688b715c804cfd39d3381db41 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Wed, 15 Jun 2022 19:41:37 -0400 Subject: [PATCH 1/5] fix(item): multiple input appearance when using datetime --- core/src/components/item/item.scss | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/core/src/components/item/item.scss b/core/src/components/item/item.scss index 46d792fa76e..1a671efbba8 100644 --- a/core/src/components/item/item.scss +++ b/core/src/components/item/item.scss @@ -493,6 +493,18 @@ button, a { position: relative; } +// Chrome injects host styles that conflict with the +// positioning of ion-datetime. +// These styles reset the position so that ion-datetime +// displays correctly with multiple inputs in an item. +:host(.item-multiple-inputs) { + @include rtl() { + ::slotted(ion-datetime) { + @include position-horizontal(0, 0); + } + } +} + // Item Textarea // -------------------------------------------------- From d5a8ec4ca6e0b5ac70f5e063ad5cb5ae97050a43 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 16 Jun 2022 11:39:17 -0400 Subject: [PATCH 2/5] fix(): explicitly set top/left styles for datetime --- core/src/components/datetime/datetime.scss | 7 +++++-- core/src/components/item/item.scss | 12 ------------ 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/core/src/components/datetime/datetime.scss b/core/src/components/datetime/datetime.scss index d8cc5382506..62ef59c12e7 100644 --- a/core/src/components/datetime/datetime.scss +++ b/core/src/components/datetime/datetime.scss @@ -341,9 +341,12 @@ * Explicit position values are required here * as pseudo element positioning is incorrect * in older implementations of css grid. + * + * TODO: FW-1720: Remove top/left styles when depreciating iOS 13 support */ - - @include position(50%, null, null, 50%); + top: 50%; + /* stylelint-disable-next-line property-disallowed-list */ + left: 50%; position: absolute; diff --git a/core/src/components/item/item.scss b/core/src/components/item/item.scss index 1a671efbba8..46d792fa76e 100644 --- a/core/src/components/item/item.scss +++ b/core/src/components/item/item.scss @@ -493,18 +493,6 @@ button, a { position: relative; } -// Chrome injects host styles that conflict with the -// positioning of ion-datetime. -// These styles reset the position so that ion-datetime -// displays correctly with multiple inputs in an item. -:host(.item-multiple-inputs) { - @include rtl() { - ::slotted(ion-datetime) { - @include position-horizontal(0, 0); - } - } -} - // Item Textarea // -------------------------------------------------- From c476072978fc4d967405453d7e8fc053066a9cd9 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 16 Jun 2022 13:34:28 -0400 Subject: [PATCH 3/5] Update core/src/components/datetime/datetime.scss Co-authored-by: Liam DeBeasi --- core/src/components/datetime/datetime.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/components/datetime/datetime.scss b/core/src/components/datetime/datetime.scss index 62ef59c12e7..71d9c76dea4 100644 --- a/core/src/components/datetime/datetime.scss +++ b/core/src/components/datetime/datetime.scss @@ -344,6 +344,7 @@ * * TODO: FW-1720: Remove top/left styles when depreciating iOS 13 support */ + /* stylelint-disable-next-line property-disallowed-list */ top: 50%; /* stylelint-disable-next-line property-disallowed-list */ left: 50%; From 0d9985255ddd8d601cd80798a8b83cba7ccfaabc Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 16 Jun 2022 13:34:33 -0400 Subject: [PATCH 4/5] Update core/src/components/datetime/datetime.scss Co-authored-by: Liam DeBeasi --- core/src/components/datetime/datetime.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/components/datetime/datetime.scss b/core/src/components/datetime/datetime.scss index 71d9c76dea4..ab93344b6aa 100644 --- a/core/src/components/datetime/datetime.scss +++ b/core/src/components/datetime/datetime.scss @@ -342,7 +342,7 @@ * as pseudo element positioning is incorrect * in older implementations of css grid. * - * TODO: FW-1720: Remove top/left styles when depreciating iOS 13 support + * TODO: FW-1720: Remove top/left styles when deprecating iOS 13 support */ /* stylelint-disable-next-line property-disallowed-list */ top: 50%; From 3bd975520aa97a72468e54c8917897c22336a282 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 16 Jun 2022 14:06:34 -0400 Subject: [PATCH 5/5] chore(): lint --- core/src/components/datetime/datetime.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/components/datetime/datetime.scss b/core/src/components/datetime/datetime.scss index ab93344b6aa..6878510a262 100644 --- a/core/src/components/datetime/datetime.scss +++ b/core/src/components/datetime/datetime.scss @@ -337,6 +337,9 @@ :host .calendar-day:after { @include border-radius(32px, 32px, 32px, 32px); @include padding(4px, 4px, 4px, 4px); + + position: absolute; + /** * Explicit position values are required here * as pseudo element positioning is incorrect @@ -349,8 +352,6 @@ /* stylelint-disable-next-line property-disallowed-list */ left: 50%; - position: absolute; - width: 32px; height: 32px;