-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textarea): add start and end slots #28441
Conversation
* we wrap both the start and end slots in separate | ||
* elements and apply our padding styles to that instead. | ||
*/} | ||
<div class="start-slot-wrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If desired, I can hide these wrappers via CSS or avoid rendering them entirely if there isn't any slotted content provided. I figured it'd be better to keep things simple since keeping them doesn't hurt anything aside from having an extra node in the DOM, but I'm cool with making that change.
display: flex; | ||
|
||
position: relative; | ||
|
||
flex-grow: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These weren't doing anything and were likely a copy-paste goof while adding the modern syntax; .native-wrapper
is set to display: grid
a few lines below this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with minor change request. Everything works as intended!
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Issue number: Part of #26297
What is the current behavior?
With the modern form control syntax, it is not possible to add icon buttons or other decorators to the sides of
ion-textarea
, as you can withion-item
.What is the new behavior?
start
andend
slots added. While making this change, I also tweaked the CSS selectors responsible for translating the label above the input with"stacked"
and"floating"
placements, merging this logic into a single class managed by the TSX. I needed to add a new class for whether slot content is present, so the selectors were getting unwieldy otherwise.Docs PR TBA; I plan on knocking out all three components at once when the features are all complete, to make dev builds easier to manage.
Does this introduce a breaking change?
Other information