From ab072cbd53e193c08720c75f5dbd7ef51d40e115 Mon Sep 17 00:00:00 2001 From: Steven Ribeiro Date: Fri, 26 Jul 2024 23:36:45 +0200 Subject: [PATCH 1/2] fix(ionTabButton): add onPointerDown, add onTouchEnd, add onTouchMove missing HTML types closes #29174 --- .../src/components/navigation/IonTabButton.tsx | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/navigation/IonTabButton.tsx b/packages/react/src/components/navigation/IonTabButton.tsx index 915761660e7..968e5a43796 100644 --- a/packages/react/src/components/navigation/IonTabButton.tsx +++ b/packages/react/src/components/navigation/IonTabButton.tsx @@ -10,6 +10,9 @@ type Props = LocalJSX.IonTabButton & routerOptions?: RouterOptions; ref?: React.Ref; onClick?: (e: CustomEvent) => void; + onPointerDown?: React.PointerEventHandler; + onTouchEnd?: React.TouchEventHandler; + onTouchMove?: React.TouchEventHandler; }; export const IonTabButton = /*@__PURE__*/ (() => @@ -40,8 +43,16 @@ export const IonTabButton = /*@__PURE__*/ (() => * component would result in duplicate handler calls. */ // eslint-disable-next-line @typescript-eslint/no-unused-vars - const { onClick, ...rest } = this.props; - return ; + const { onClick, onPointerDown, onTouchEnd, onTouchMove, ...rest } = this.props; + return ( + + ); } static get displayName() { From 750d8616cf2af58410fe4f81ea7973d7fb1afecc Mon Sep 17 00:00:00 2001 From: steven Date: Thu, 1 Aug 2024 07:12:09 +0200 Subject: [PATCH 2/2] remove properties --- .../react/src/components/navigation/IonTabButton.tsx | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/react/src/components/navigation/IonTabButton.tsx b/packages/react/src/components/navigation/IonTabButton.tsx index 968e5a43796..c78af7ec925 100644 --- a/packages/react/src/components/navigation/IonTabButton.tsx +++ b/packages/react/src/components/navigation/IonTabButton.tsx @@ -43,16 +43,8 @@ export const IonTabButton = /*@__PURE__*/ (() => * component would result in duplicate handler calls. */ // eslint-disable-next-line @typescript-eslint/no-unused-vars - const { onClick, onPointerDown, onTouchEnd, onTouchMove, ...rest } = this.props; - return ( - - ); + const { onClick, ...rest } = this.props; + return ; } static get displayName() {