feat(android-full-screen): add cordova-plugin-fullscreen support #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
requested changes
Mar 26, 2017
| * Using Android 4.0+, you can use true full screen in "lean mode", the way you see in apps like YouTube, expanding the app right to the edges of the screen, hiding the status and navigation bars until the user next interacts. This is ideally suited to video or cut-scene content. | ||
| * | ||
| * In Android 4.4+, however, you can now enter true full screen, fully interactive immersive mode. In this mode, your app will remain in true full screen until you choose otherwise; users can swipe down from the top of the screen to temporarily display the system UI. | ||
| * |
| export class AndroidFullScreen { | ||
| /** | ||
| * Is this plugin supported? | ||
| */ |
There was a problem hiding this comment.
could you please specify the return type for each method?
Example:
/**
* Is this plugin supported?
* @return {Promise<void>}
*/
There was a problem hiding this comment.
Sure, sorry. I see both @return and @returns in other plugins - does this make any difference?
|
Updated and rebased on master. |
|
Thanks @tkem I also updated the templates for |
|
Thank you for maintaining this and making life a little easier for all of us ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for cordova-plugin-fullscreen.
BTW, I think the
@usageexamples created by e.g.should be updated to Ionic Native v3 - they still use the old static method syntax.