feat(intel-security): Add com-intel-security-cordova-plugin Support #1256

ehorodyski · 2017-03-25T19:03:49Z

This PR adds support for the com-intel-security-cordova-plugin.

Applications will not bomb if the plugin is not installed or user is running in browser.

ihadeed · 2017-03-26T01:32:30Z

src/@ionic-native/plugins/intel-security/index.ts

+/**
+ * @hidden
+ */
+export class IntelSecurityData {


You can add another @Plugin() tag here with a different pluginRef and no repo property. You can also make it injectable if you think that's a better way to do it.

If you make it Injectable. Then the class above should be empty and only used for documentation purposes.

Apply this fix to the class below as well.

ihadeed · 2017-03-26T01:35:11Z

src/@ionic-native/plugins/intel-security/index.ts

+  * @param id {string} Storage resource identifier.
+  * @returns {Promise<any>} Returns a Promise that resolves with the instanceID of the created data instance, or rejects with an error.
+  */
+  createFromData(data: string): Promise<any> {


After making the changes I mentioned above, you can remove the if (!window.intel) ... check and add the regular @Cordova decorator.

Apply this fix to all methods below.

ehorodyski · 2017-03-26T18:00:06Z

Changes made, thank you!

The only thing I can't figure out is now the console is logging cordova_not_available from polyfills.js.

ihadeed

Looks good now. Just one last change mentioned above and then this will be good to go.

ihadeed · 2017-03-26T23:48:43Z

src/@ionic-native/plugins/intel-security/index.ts

 export class IntelSecurityData {

  /**
  * This creates a new instance of secure data using plain-text data.
  * @param id {string} Storage resource identifier.
  * @returns {Promise<any>} Returns a Promise that resolves with the instanceID of the created data instance, or rejects with an error.
  */
+  @Cordova()


Since now we have the Cordova decorator, there is no need to write any functionally. We can just have the keyword return in there.

If the real method takes an object as a parameter instead of a string, then we need to change the parameter type in the method definition/docs.

ihadeed · 2017-03-27T14:52:17Z

src/@ionic-native/plugins/intel-security/index.ts

@@ -4,32 +4,6 @@ import { Injectable } from '@angular/core';
 declare var window: any;
 declare var intel: any;

-export interface IntelSecurityDataOptions {


I liked the interface better than having the params listed below.

ihadeed · 2017-03-27T14:53:46Z

src/@ionic-native/plugins/intel-security/index.ts

+    this.storage = new IntelSecurityStorage();
+    this.data = new IntelSecurityData();
+
+    try {


Remove these 5 lines as they are not needed.

ihadeed · 2017-03-27T14:54:12Z

src/@ionic-native/plugins/intel-security/index.ts

+  pluginName: 'IntelSecurity',
+  plugin: 'com-intel-security-cordova-plugin',
+  pluginRef: 'intel.security.secureData',
+  repo: ''


remove the repo property completely.

ihadeed · 2017-03-27T14:54:40Z

src/@ionic-native/plugins/intel-security/index.ts

+ *   .catch((error: any) => console.log(error));
+ *
+ * ```
+ */


Add the following

* @classes * IntelSecurityData * IntelSecurityStorage

ihadeed · 2017-03-27T14:59:08Z

src/@ionic-native/plugins/intel-security/index.ts

+  * @param [options.webOwners] {String[]} List of trusted web domains.
+  * @returns {Promise<any>} Returns a Promise that resolves with the instanceID of the created data instance, or rejects with an error.
+  */
+  @Cordova()


Replace all @Cordova() decorators with @Cordova({ otherPromise: true }).

I just realized their plugin returns a promise instead of using callbacks. This decorator config will convert their Q promise to a regular ES6 Promise.

ehorodyski · 2017-03-27T15:40:52Z

Thanks @ihadeed -- I'm working on the changes now.

Some "author notes" from me: :-P

I didn't set IntelSecurityData or IntelSecurityStorage as Injectable classes because they really work in-tandem. It's my attempt at trying to keep the original intel.security.storage and intel.security.data namespacing in-tact for consumers.
The hesitation on adding Interfaces is based on the lack of examples and documentation from Intel on the additional (optional) properties. Some of the method documentations state that there are parameters that exist that aren't currently being used...also, some methods use object containers as a parameter, but there are a total of like 2 properties for it. Actually, I think if any method in this plugin has more than one parameter it's expected to be passed in as an object container.

Anyway, changes coming soon once I can verify they work in a sample Ionic project. Thank you for the help and guidance through this!

ehorodyski · 2017-03-27T16:54:34Z

@ihadeed -- I'm running into this issue now after changing the @Cordova() decorator:

TypeError: Cannot read property 'constructor' of null
    at checkAvailability (main.js:81923)
    at callCordovaPlugin (main.js:82018)
    at main.js:82046
    at main.js:55921
    at new t (polyfills.js:3)
    at tryNativePromise (main.js:55920)
    at getPromise (main.js:55928)
    at wrapOtherPromise (main.js:82045)
    at main.js:82139
    at value (main.js:115414)
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (main.js:35928)
    at t.invoke (polyfills.js:3)
    at e.run (polyfills.js:3)
    at polyfills.js:3

ihadeed · 2017-03-27T17:27:44Z

@ehorodyski just pushed a commit to the master branch to fix this issue.

…o feat/intelSecurity

Eric J Horodyski and others added 5 commits March 24, 2017 08:34

Initial plugin pass

ed40d15

Remove unneeded imports, or else plugins will not build.

e30d03c

Add try-catch blocks.

b4eb6af

Applications will not bomb if the plugin is not installed or user is running in browser.

handle missing intel variable.

6b2f302

Add documentation

21bb1c1

ihadeed requested changes Mar 26, 2017

View reviewed changes

Conform to Cordova decorators.

53a64f9

ihadeed requested changes Mar 26, 2017

View reviewed changes

Eric J Horodyski added 2 commits March 27, 2017 10:18

Add IntelSecurityDataOptions

72e0d71

Update plugin to use plain return method statements.

81134f6

ihadeed reviewed Mar 27, 2017

View reviewed changes

ihadeed requested changes Mar 27, 2017

View reviewed changes

Eric J Horodyski added 2 commits March 27, 2017 13:30

Merge branch 'master' of https://github.com/driftyco/ionic-native int…

14f469b

…o feat/intelSecurity

Better conform to Ionic Native

d60fdb7

ihadeed approved these changes Mar 27, 2017

View reviewed changes

ihadeed merged commit aedc9d6 into danielsogl:master Mar 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(intel-security): Add com-intel-security-cordova-plugin Support #1256

feat(intel-security): Add com-intel-security-cordova-plugin Support #1256

ehorodyski commented Mar 25, 2017

ihadeed Mar 26, 2017

ihadeed Mar 26, 2017

ehorodyski commented Mar 26, 2017

ihadeed left a comment

ihadeed Mar 26, 2017

ihadeed Mar 27, 2017

ihadeed Mar 27, 2017

ihadeed Mar 27, 2017

ihadeed Mar 27, 2017

ihadeed Mar 27, 2017

ehorodyski commented Mar 27, 2017

ehorodyski commented Mar 27, 2017

ihadeed commented Mar 27, 2017

feat(intel-security): Add com-intel-security-cordova-plugin Support #1256

feat(intel-security): Add com-intel-security-cordova-plugin Support #1256

Conversation

ehorodyski commented Mar 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ehorodyski commented Mar 26, 2017

ihadeed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ehorodyski commented Mar 27, 2017

ehorodyski commented Mar 27, 2017

ihadeed commented Mar 27, 2017