Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Storage: .create() Promise never resolved/rejected in browser #1268

Closed
jonaszuberbuehler opened this issue Mar 27, 2017 · 4 comments
Closed

Comments

@jonaszuberbuehler
Copy link

Calling secureStorage.create() in browser (ionic serve) the returned Promise is never resolved/rejected when run in browser.

I'm using the following code:

this.platform.ready()
        .then(() => {
            this.secureStorage.create('test')
                .then(
                    data => console.log(data),
                    error => console.log(error))
        });

None of the callbacks gets ever called. The same works perfectly for all the other plugins I'm using.

Anything I'm missing here?

@ihadeed
Copy link
Collaborator

ihadeed commented Mar 27, 2017

Sorry, the documentation is wrong/outdated. The plugin doesn't support the browser platform.

@jonaszuberbuehler
Copy link
Author

@ihadeed Thanks for your answer. But in this case should't the Promise be rejected with a meaningful reason?

ihadeed added a commit that referenced this issue Mar 27, 2017
@ihadeed
Copy link
Collaborator

ihadeed commented Mar 27, 2017

Just pushed a commit to fix that :)

@jonaszuberbuehler
Copy link
Author

@ihadeed Awesome, thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants