Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocialSharing: Add missing methods (setIPadPopupCoordinates) #1288

Closed
FdezRomero opened this issue Mar 29, 2017 · 2 comments · Fixed by #1497
Closed

SocialSharing: Add missing methods (setIPadPopupCoordinates) #1288

FdezRomero opened this issue Mar 29, 2017 · 2 comments · Fixed by #1497
Labels
improve plugin

Comments

@FdezRomero
Copy link
Contributor

Hi there!

I noticed there are some missing methods in the SocialSharing plugin, especially setIPadPopupCoordinates, which is needed to specify the position and size of the button the user has pressed so that the sharing popup on iPad can be positioned according to Apple's guidelines. And as you all know, not doing this may be a reason for app rejection.

Would also be a good opportunity to review and add all the other missing methods. You can check them here: https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/blob/master/www/SocialSharing.js

Thanks!
@danielsogl danielsogl mentioned this issue May 7, 2017
Merged
@danielsogl
Copy link
Owner

Hey @FdezRomero,

I added the method. Wait for the next release.

@FdezRomero
Copy link
Contributor Author

Great! Thanks @danielsogl 👍 I was going to submit a PR but I don't fully understand (yet) the inner workings of the changes made in 3.x.

ihadeed pushed a commit that referenced this issue May 9, 2017
@danielsogl @ihadeed
feat(social-sharing): add setIPadPopupCoordinates method (#1497)
65a8095 
* refactor(social sharing): added missing method

fix #1288

* Update index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improve plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(social sharing): added missing method
3 participants
@FdezRomero @ihadeed @danielsogl