Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native-storage missing NativeStorage.keys function #1415

Closed
tedliang-aa opened this issue Apr 25, 2017 · 2 comments · Fixed by #1495
Closed

native-storage missing NativeStorage.keys function #1415

tedliang-aa opened this issue Apr 25, 2017 · 2 comments · Fixed by #1495

Comments

@tedliang-aa
Copy link

This function NativeStorage.getItem("reference_to_value", <success-callback>, <error-callback>) is missing on the @ionic-native/native-storage wrapper.

Is it intentional? or it's a new feature that is not yet covered by the wrapper?
@danielsogl
Copy link
Owner

Hey @tedliang-asahi, the requested methods are implemented. Check the latest native release.
But I added the missing keys() method.

@danielsogl danielsogl mentioned this issue May 7, 2017
Merged
ihadeed pushed a commit that referenced this issue May 7, 2017
@danielsogl @ihadeed
fix(native-storage): add missing keys method (#1495)
8311aaf 
fix #1415
@tedliang-aa
Copy link
Author

Great! Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(native-storage): missing method
2 participants
@danielsogl @tedliang-aa