feat(FCM): support Firebase Cloud Messaging plugin #1449
Conversation
| * | ||
| * @usage | ||
| * ``` | ||
| * import { FCM } from 'ionic-native'; |
There was a problem hiding this comment.
Please add typescript to the markup ```typescript
| * ``` | ||
| * import { FCM } from 'ionic-native'; | ||
| * | ||
| * constructor(private fcm: FCM) { |
There was a problem hiding this comment.
The usage part is a bit to short. Can you describe the plugin a bit more? Orientate you by other plugins.
Don't put the plugin method call in to the constructor.
There was a problem hiding this comment.
Added additional examples in the usage section and in docs for each function
| */ | ||
| @Cordova({ | ||
| observable: true, | ||
| successIndex: 0 |
| /** | ||
| * Get's device's current registration id | ||
| * | ||
| * ```typescript |
There was a problem hiding this comment.
Keep all usage examples in the main block above the @Plugin decorator. Do not add any usage documentation above the method declaration.
| * @returns {Promise<any>} Returns a promise resolving in result of subscribing to a topic | ||
| */ | ||
| @Cordova({ | ||
| callbackOrder: 'reverse' |
There was a problem hiding this comment.
This method should not have callbackOrder: 'reverse'. See https://github.com/fechanique/cordova-plugin-fcm/blob/master/www/FCMPlugin.js#L8
| * @returns {Promise<any>} Returns a promise resolving in result of unsubscribing from a topic | ||
| */ | ||
| @Cordova({ | ||
| callbackOrder: 'reverse' |
There was a problem hiding this comment.
This method should not have callbackOrder: 'reverse'. See https://github.com/fechanique/cordova-plugin-fcm/blob/master/www/FCMPlugin.js#L12
Added Firebase Cloud Messaging plugin.
Tested it out on Android, test on iOS is coming.
Event functions (onTokenChange, onNotification) repurposed to be observables.
Code feedback would be great, as it is my first plugin wrapper.